Summary: | Date not showing on Details page when patron is going to expire | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Patrons | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, kyle.m.hall, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.05.00, 19.11.06, 19.05.11
|
Circulation function: | |
Attachments: |
Bug 25299: Show soon to expire patron date
Bug 25299: Show soon to expire patron date Bug 25299: Show soon to expire patron date |
Description
David Cook
2020-04-28 01:39:35 UTC
Created attachment 103819 [details] [review] Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/XXXX Renew or Edit details" Created attachment 103822 [details] [review] Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/XXXX Renew or Edit details" Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Without this patch the display was incomplete on patron detail tab Thanks, Frédéric. Much appreciated! Created attachment 103879 [details] [review] Bug 25299: Show soon to expire patron date This patch fixes the call to show the patron expiry date on the Details page when the patron is soon to expire. Test plan: 0. Do not apply patch yet 1. Create a patron 2. Set patron's date expiry to 3 days from today 3. Go to Details tab 4. Note message "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5. Apply patch 4. Note message pattern "Expiration: Patron's card will expire soon. Patron's card expires on XX/XX/XXXX Renew or Edit details" Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Without this patch the dispay was incomplete on patron detail tab Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Good catch! (In reply to Katrin Fischer from comment #5) > Good catch! Thanks but I can't take the credit. We upgraded one of our libraries to 19.11 recently, and a librarian there has a very keen eye! Nice work everyone! Pushed to master for 20.05 Backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |