| Summary: | Unnecessary update of framework in ModBiblioMarc | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, f.demians, fridolin.somers, jonathan.druart, kyle, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
21.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 25306: Remove framework paramter from ModBiblioMarc
Bug 25306: Remove framework paramter from ModBiblioMarc Bug 25306: Remove framework paramter from ModBiblioMarc Bug 25306: Remove framework paramter from ModBiblioMarc Bug 25306: (QA follow-up) Remove framework from bulkmarcimport |
||
|
Description
Nick Clemens (kidclamp)
2020-04-28 18:36:16 UTC
Created attachment 103876 [details] [review] Bug 25306: Remove framework paramter from ModBiblioMarc I suppose you have searched for all occurrences of ModBiblio, but why is you patch also modifying a AddBiblio call? This one:
- eval { ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record, '', { defer_marc_save => 1 } ) };
+ eval { ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record, $framework, { defer_marc_save => 1 } ) };
(In reply to Frédéric Demians from comment #2) > I suppose you have searched for all occurrences of ModBiblio, but why is you > patch also modifying a AddBiblio call? This one: > > - eval { ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record, '', { > defer_marc_save => 1 } ) }; > + eval { ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record, > $framework, { defer_marc_save => 1 } ) }; In that bit of code we are passing the framework to ModBiblioMarc after this call - the $framework variable is the same during both calls, moving it to the AddBiblio means we can remove it from the later call Sorry does not apply on current master. I get : Applying: Bug 25306: Remove framework paramter from ModBiblioMarc error: sha1 information is lacking or useless (C4/Biblio.pm). error: could not build fake ancestor Created attachment 114900 [details] [review] Bug 25306: Remove framework paramter from ModBiblioMarc Tested with : For a framework (not the default) : Creation of a biblio record Edition of this biblio record Creation of an item of this record Creation of an item of this record ./misc/batchRepairMissingBiblionumbers.pl OK prove t/db_dependent/Biblio/ModBiblioMarc.t OK Created attachment 114923 [details] [review] Bug 25306: Remove framework paramter from ModBiblioMarc Tested with : For a framework (not the default) : Creation of a biblio record Edition of this biblio record Creation of an item of this record Creation of an item of this record ./misc/batchRepairMissingBiblionumbers.pl OK prove t/db_dependent/Biblio/ModBiblioMarc.t OK Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 115010 [details] [review] Bug 25306: Remove framework paramter from ModBiblioMarc Tested with : For a framework (not the default) : Creation of a biblio record Edition of this biblio record Creation of an item of this record Creation of an item of this record ./misc/batchRepairMissingBiblionumbers.pl OK prove t/db_dependent/Biblio/ModBiblioMarc.t OK Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 115011 [details] [review] Bug 25306: (QA follow-up) Remove framework from bulkmarcimport One last instance of ModBiblioMarc in bulkmarcimport still passed the frameworkcode. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected, tests pass and no regressions found.. I added a follow up for the final case where ModBiblioMarc was being called with a frameworkcode. Passing QA Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |