| Summary: | Add optional skip_merge parameter to ModAuthority | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | MARC Authority data support | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, jonathan.druart, kyle, martin.renvoize, phil, tomascohen, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.07
|
|
| Circulation function: | |||
| Attachments: |
Bug 25313: Add skip_merge to ModAuthority
Bug 25313: Add skip_merge to ModAuthority Bug 25313: Regression tests Bug 25313: Add skip_merge to ModAuthority Bug 25313: (QA follow-up) DelAuthority tests |
||
|
Description
Marcel de Rooy
2020-04-29 14:18:21 UTC
Created attachment 103954 [details] [review] Bug 25313: Add skip_merge to ModAuthority Sometimes you know that the merge is useless, since the reporting tag did not change. Might be handy in batch processing of authority records. Test plan: Pick an authority with a few linked biblio recs (so that it will immediately merge; lower than MergeLimit). Open authority record and save it. Verify that a linked biblio record was merged. Check time in 005. You proved that this patch does not break the regular process. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 104217 [details] [review] Bug 25313: Add skip_merge to ModAuthority Sometimes you know that the merge is useless, since the reporting tag did not change. Might be handy in batch processing of authority records. Test plan: Pick an authority with a few linked biblio recs (so that it will immediately merge; lower than MergeLimit). Open authority record and save it. Verify that a linked biblio record was merged. Check time in 005. You proved that this patch does not break the regular process. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> QA team: This was signed off on May 3 and we are August 10 now ? 1 file changed, 4 insertions(+), 3 deletions(-) Really not that hard ;) Created attachment 108055 [details] [review] Bug 25313: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 108056 [details] [review] Bug 25313: Add skip_merge to ModAuthority Sometimes you know that the merge is useless, since the reporting tag did not change. Might be handy in batch processing of authority records. Test plan: Pick an authority with a few linked biblio recs (so that it will immediately merge; lower than MergeLimit). Open authority record and save it. Verify that a linked biblio record was merged. Check time in 005. You proved that this patch does not break the regular process. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 108057 [details] [review] Bug 25313: (QA follow-up) DelAuthority tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Tomás Cohen Arazi from comment #6) > Created attachment 108057 [details] [review] [review] > Bug 25313: (QA follow-up) DelAuthority tests > > Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Thx Tomas ! Even a test ;) Where are we going to set this flag? (In reply to Jonathan Druart from comment #8) > Where are we going to set this flag? Future submission(s). Already using too in local script. Cant hurt too have it already just like iirc DelAuthority. Pushed to master for 20.11, thanks to everybody involved! Backported to 20.05.x for 20.05.07 Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. |