| Summary: | Add support for circulation status 11 ( claimed returned ) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | SIP2 | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, colin.campbell, lucas, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | 25344 | ||
| Bug Blocks: | 25348 | ||
| Attachments: |
Bug 25347: Add support for circulation status 11 ( claimed returned )
Bug 25347: Add support for circulation status 11 ( claimed returned ) Bug 25347: Add support for circulation status 11 ( claimed returned ) Bug 25347: Add support for circulation status 11 ( claimed returned ) |
||
|
Description
Kyle M Hall (khall)
2020-05-01 16:16:15 UTC
Created attachment 104126 [details] [review] Bug 25347: Add support for circulation status 11 ( claimed returned ) Now that we have return claims in Koha, we should support the SIP2 "circulation status" value 11, "claimed returned". Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Created attachment 104173 [details] [review] Bug 25347: Add support for circulation status 11 ( claimed returned ) Now that we have return claims in Koha, we should support the SIP2 "circulation status" value 11, "claimed returned". Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 108078 [details] [review] Bug 25347: Add support for circulation status 11 ( claimed returned ) Now that we have return claims in Koha, we should support the SIP2 "circulation status" value 11, "claimed returned". Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 108080 [details] [review] Bug 25347: Add support for circulation status 11 ( claimed returned ) Now that we have return claims in Koha, we should support the SIP2 "circulation status" value 11, "claimed returned". Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Comment on attachment 108080 [details] [review] Bug 25347: Add support for circulation status 11 ( claimed returned ) >diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm >index d5e61362bd..0950864aa2 100644 >--- a/C4/SIP/ILS/Item.pm >+++ b/C4/SIP/ILS/Item.pm >+ elsif ( Koha::Checkouts::ReturnClaims->search({ itemnumber => $self->{_object}->id, resolution => undef })->count ) { >+ return '11'; # claimed returned >+ } I see a case for a tested higher level method for knowing if an item has standing return claims. Unrelated to this bug, though. Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 enhancement missing dependencies, not backported to 19.11.x |