Summary: | Circulation and fine rules cloning from one table to another does not copy "current checkouts allowed" | ||
---|---|---|---|
Product: | Koha | Reporter: | Joe Sikowitz <joe> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | 1joynelson, gmcharlt, jonathan.druart, lucas |
Version: | 19.11 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
19.11.06, 19.05.11
|
|
Circulation function: | |||
Attachments: |
Example of original circ rules
Example of cloned circ rules Bug 25400: [< 20.05] Fix cloning of circulation rules Bug 25400: [< 20.05] Fix cloning of circulation rules Bug 25400: [< 20.05] Fix cloning of circulation rules |
Description
Joe Sikowitz
2020-05-06 20:18:50 UTC
Created attachment 104455 [details]
Example of original circ rules
Created attachment 104456 [details]
Example of cloned circ rules
Hi Joe, I think this is a duplicate of the very old bug 4225. Do you agree? Joe, it works for me, which exact version of Koha are you using? Hi Katrin, I looked at bug 4225 and it does look similar. I wasn't sure what only cloning the "top table" of rules meant since the bug I identified deals with the top most table on the page. That's why I submitted a new bug. Hi Jonathan, I am using Koha 19.05.09.000 and still seeing this issue. (In reply to Joe Sikowitz from comment #5) > Hi Katrin, I looked at bug 4225 and it does look similar. I wasn't sure what > only cloning the "top table" of rules meant since the bug I identified deals > with the top most table on the page. That's why I submitted a new bug. > > Hi Jonathan, I am using Koha 19.05.09.000 and still seeing this issue. Ah, sorry then! We also got the current checkouts in the tables below, should have checked more closely! Created attachment 104577 [details] [review] Bug 25400: [< 20.05] Fix cloning of circulation rules This patch is for 19.11 and anterior versions. The clone functionnality does not clone the "already moved rules" maxissueqty and maxonsiteissueqty. Test plan: Clone some circ rules from one branch to another Confirm that all the rules have been copied correctly Hi Jonathan, I've tested this, but it doesn't work for me when I copy from "All libraries" to any other library. Copying from library A to library B works well. Created attachment 104654 [details] [review] Bug 25400: [< 20.05] Fix cloning of circulation rules This patch is for 19.11 and anterior versions. The clone functionnality does not clone the "already moved rules" maxissueqty and maxonsiteissueqty. Test plan: Clone some circ rules from one branch to another Confirm that all the rules have been copied correctly (In reply to Katrin Fischer from comment #8) > Hi Jonathan, I've tested this, but it doesn't work for me when I copy from > "All libraries" to any other library. Copying from library A to library B > works well. Indeed, should be fixed now. Created attachment 104899 [details] [review] Bug 25400: [< 20.05] Fix cloning of circulation rules This patch is for 19.11 and anterior versions. The clone functionnality does not clone the "already moved rules" maxissueqty and maxonsiteissueqty. Test plan: Clone some circ rules from one branch to another Confirm that all the rules have been copied correctly Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested on 19.11, no errors Pushed to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |