| Summary: | Warnings in advanced editor macros routes | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | REST API | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bgkriegel, jonathan.druart, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 17268 | ||
| Bug Blocks: | |||
| Attachments: | Bug 25494: Remove warnings in advanced editor macros routes | ||
|
Description
Tomás Cohen Arazi (tcohen)
2020-05-13 21:07:08 UTC
Created attachment 104855 [details] [review] Bug 25494: Remove warnings in advanced editor macros routes There's a couple leftover 'warn's in the controller code. This patch removes that. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/advanced_editor_macros.t => FAIL: Two numbers are warned 2. Apply this patch and repeat 1 => SUCCESS: No more warns 3. Sign off :-D (In reply to Tomás Cohen Arazi from comment #1) > > To test: > 1. Run: > $ kshell > k$ prove t/db_dependent/api/v1/advanced_editor_macros.t Can this be tested in a 'legacy' install? No vagrant/docker but a simple dev install Test fails for me, but perhaps I need some other setup |