Bug 25494

Summary: Warnings in advanced editor macros routes
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: REST APIAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: RESOLVED DUPLICATE QA Contact:
Severity: enhancement    
Priority: P5 - low CC: bgkriegel, jonathan.druart, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 17268    
Bug Blocks:    
Attachments: Bug 25494: Remove warnings in advanced editor macros routes

Description Tomás Cohen Arazi (tcohen) 2020-05-13 21:07:08 UTC
To reproduce:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/advanced_editor_macros.t
=> FAIL: Two numbers are warned
Comment 1 Tomás Cohen Arazi (tcohen) 2020-05-13 21:34:48 UTC
Created attachment 104855 [details] [review]
Bug 25494: Remove warnings in advanced editor macros routes

There's a couple leftover 'warn's in the controller code.
This patch removes that.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/advanced_editor_macros.t
=> FAIL: Two numbers are warned
2. Apply this patch and repeat 1
=> SUCCESS: No more warns
3. Sign off :-D
Comment 2 Bernardo Gonzalez Kriegel 2020-05-14 14:27:47 UTC
(In reply to Tomás Cohen Arazi from comment #1)
> 
> To test:
> 1. Run:
>    $ kshell
>   k$ prove t/db_dependent/api/v1/advanced_editor_macros.t

Can this be tested in a 'legacy' install?
No vagrant/docker but a simple dev install
Test fails for me, but perhaps I need some other setup
Comment 3 Nick Clemens (kidclamp) 2020-05-15 11:33:04 UTC

*** This bug has been marked as a duplicate of bug 25482 ***