Bug 25507

Summary: PDF order print for German 2-pages is broken
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: AcquisitionsAssignee: Katrin Fischer <katrin.fischer>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: aleisha, jonathan.druart+koha, lucas, martin.renvoize, victor
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.01, 19.11.07, 19.05.12
Bug Depends on: 12110    
Bug Blocks:    
Attachments: Bug 25507: Fix table in basket group PDF German 2-pages
Bug 25507: Fix table in basket group PDF German 2-pages
Bug 25507: Fix table in basket group PDF German 2-pages

Description Katrin Fischer 2020-05-14 16:11:38 UTC
The table with order information is 'out of order' - the column headings don't match the content and it runs wider than the page width.

I am trying to see if maybe it's the changes from bug 18736 missing here.
Comment 1 Katrin Fischer 2020-05-14 16:20:32 UTC
Nope, it's Bug 12110: (follow-up) add French and German translation 

                $titleinfo. ($line->{order_vendornote} ? "\n----------------\nLieferantennotiz : ". $line->{order_vendornote} : '' ),                $line->{quantity},
                $line->{quantity},

We only need quantity once.
Comment 2 Katrin Fischer 2020-05-22 23:27:05 UTC
Created attachment 105295 [details] [review]
Bug 25507: Fix table in basket group PDF German 2-pages

A variable was doubled up which made the columns in the
table of orders no longer line up (different number of headers
to columns).

To test:
- Create at least one basket with one or more orders
- Close the basket
- Add the basket to a basket group manually or let Koha do it
  on closing
- Change the OrderPdfFormat system preference to 'German 2-page'
- Go to the basket group page and print the PDF of the basket
- Verify the table of orders doesn't look right and runs outside
  the page
- Apply patch
- Repeat the PDF print - now table should look right
Comment 3 David Nind 2020-06-10 08:39:12 UTC
Created attachment 105674 [details] [review]
Bug 25507: Fix table in basket group PDF German 2-pages

A variable was doubled up which made the columns in the
table of orders no longer line up (different number of headers
to columns).

To test:
- Create at least one basket with one or more orders
- Close the basket
- Add the basket to a basket group manually or let Koha do it
  on closing
- Change the OrderPdfFormat system preference to 'German 2-page'
- Go to the basket group page and print the PDF of the basket
- Verify the table of orders doesn't look right and runs outside
  the page
- Apply patch
- Repeat the PDF print - now table should look right

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2020-06-11 10:16:27 UTC
Thank you, David! The "German" fixes are a bit hard to get tested!
Comment 5 Martin Renvoize 2020-06-11 11:51:40 UTC
Created attachment 105738 [details] [review]
Bug 25507: Fix table in basket group PDF German 2-pages

A variable was doubled up which made the columns in the
table of orders no longer line up (different number of headers
to columns).

To test:
- Create at least one basket with one or more orders
- Close the basket
- Add the basket to a basket group manually or let Koha do it
  on closing
- Change the OrderPdfFormat system preference to 'German 2-page'
- Go to the basket group page and print the PDF of the basket
- Verify the table of orders doesn't look right and runs outside
  the page
- Apply patch
- Repeat the PDF print - now table should look right

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2020-06-11 11:52:06 UTC
Trivial fix that passes qa scripts, makes sense and passes local testing.

Passing QA
Comment 7 Jonathan Druart 2020-06-15 09:59:55 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 8 Lucas Gass 2020-06-17 22:26:25 UTC
backported to 20.05.x for 20.05.01
Comment 9 Aleisha Amohia 2020-06-19 03:46:10 UTC
backported to 19.11.x for 19.11.07
Comment 10 Victor Grousset/tuxayo 2020-06-19 04:43:59 UTC
Backported to 19.05.x branch for 19.05.12
Comment 11 Katrin Fischer 2020-06-20 16:18:14 UTC
Thx all!