Summary: | Remove useless libjs-jquery dependency | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Packaging | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, jonathan.druart, lucas, martin.renvoize, mirko, mtj, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.02, 19.11.08, 19.05.14
|
|
Circulation function: | |||
Attachments: |
Bug 25509: Remove useless libjs-jquery dependency
Bug 25509: Remove useless libjs-jquery dependency Bug 25509: Remove useless libjs-jquery dependency |
Description
David Cook
2020-05-15 03:58:40 UTC
Created attachment 104911 [details] [review] Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Looking back at 97232eee15e, the original "koha" package by Lars had "libjs-jquery", "tinymce2", and "libjs-yui". You can see there that he was overriding the bundled jquery, tinymce, and yui with the Debian package versions. But we don't do that anymore. Created attachment 105951 [details] [review] Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Yahoo. Cheers, Jonathan! Created attachment 106075 [details] [review] Bug 25509: Remove useless libjs-jquery dependency We don't use the libjs-jquery package, so we should remove the dependency. To Test: 1) Build package (out of scope of test plan) 2) Install package 3) Note that libjs-jquery is marked by apt as no longer required 4) Remove libjs-jquery package from system and note how it doesn't take koha-common with it Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice spot.. Passing QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.02 backported to 19.11.x for 19.11.08 Backported to 19.05.x branch for 19.05.14 |