Bug 25555

Summary: Holds Queue sorts patrons by firstname
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Hold requestsAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: aleisha, caroline.cyr-la-rose, gmcharlt, victor
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.01
Circulation function:
Bug Depends on:    
Bug Blocks: 25747    
Attachments: Bug 25555: Invert patron name in holdsqueue.tt
Bug 25555: Invert patron name in holdsqueue.tt
Bug 25555: Invert patron name in holdsqueue.tt

Description Lucas Gass (lukeg) 2020-05-20 17:54:51 UTC
The Holds Queue table sorts name by firstname which is less helpful than sorting by surname
Comment 1 Lucas Gass (lukeg) 2020-05-20 18:03:40 UTC
Created attachment 105159 [details] [review]
Bug 25555: Invert patron name in holdsqueue.tt

TEST PLAN:
1. Have multiple holds from multiple patrons and run the holds queue cron to populate the holds queue list.
2. Try sorting by patron and see that is sorts based on first name.
3. Apply patch
4. Try sorting again and now it should sort by surname.
Comment 2 Victor Grousset/tuxayo 2020-05-31 21:32:05 UTC
Created attachment 105447 [details] [review]
Bug 25555: Invert patron name in holdsqueue.tt

TEST PLAN:
1. Have multiple holds from multiple patrons and run the holds queue cron to populate the holds queue list.
2. Try sorting by patron and see that is sorts based on first name.
3. Apply patch
4. Try sorting again and now it should sort by surname.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 3 Victor Grousset/tuxayo 2020-05-31 21:32:56 UTC
It works! :D
Comment 4 Katrin Fischer 2020-06-14 11:45:31 UTC
Created attachment 105857 [details] [review]
Bug 25555: Invert patron name in holdsqueue.tt

TEST PLAN:
1. Have multiple holds from multiple patrons and run the holds queue cron to populate the holds queue list.
2. Try sorting by patron and see that is sorts based on first name.
3. Apply patch
4. Try sorting again and now it should sort by surname.

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Jonathan Druart 2020-06-15 10:00:15 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 6 Lucas Gass (lukeg) 2020-06-17 22:16:36 UTC
backported to 20.05.x for 20.05.01
Comment 7 Aleisha Amohia 2020-06-19 03:34:12 UTC
enhancement, not backporting to 19.11.x
Comment 8 Caroline Cyr La Rose 2020-08-21 14:00:44 UTC
For the sake of release notes, I'm classifying this as a bug rather than an enhancement. 

Feel free to change it back if you think this is wrong.