Bug 25569

Summary: decreaseLoanHighHolds will decrease loan too often
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, klas.blomberg, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25566
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Nick Clemens (kidclamp) 2020-05-21 13:53:34 UTC
The routine checkHighHolds uses CanItemBeReserved to count the number of available items, however, since we must pass the current borrower and check their ability to hold the items, many of the checks in that routine are not necessarily applicable. Additionally the count of holds on the record may be inaccurate:

1 - The borrowers own holds shouldn't be counted - if I am getting several books for a book group or a number of dvds in a set I shouldn't shorten my own loan period
2 - My hold limits may prevent me from placing more holds, but are not relevant in determining if the item is in high demand
3 - My fines may prevent me from placing holds, but shouldn't shorten my loan period
4 - If 6 patrons from another library who can't hold my libraries items have holds on their libraries item, my loan period shouldn't be decreased as they can't get my item anyways
5 - etc.
Comment 1 Klas Blomberg 2020-08-31 08:25:31 UTC
*** Bug 21733 has been marked as a duplicate of this bug. ***