Summary: | Something wrong with KOHA_HOME (?) | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Packaging | Assignee: | Bugs List <koha-bugs> |
Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dcook, joonas.kylmala, m.de.rooy, martin.renvoize, mirko, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 25586: (bug 25618 follow-up) Use KOHA_HOME to guess pkg bin dir
Bug 25586: (bug 25618 follow-up) Use KOHA_HOME to guess pkg bin dir |
Description
Jonathan Druart
2020-05-22 14:00:53 UTC
debian/templates/koha-conf-site.xml.in: <intranetdir>/usr/share/koha/intranet/cgi-bin</intranetdir> debian/koha-common.default:KOHA_HOME="/usr/share/koha" debian/scripts/koha-functions.sh: KOHA_HOME=$(run_safe_xmlstarlet $instancename intranetdir) KOHA_HOME can be: * /usr/share/koha # pkg install * /kohadevbox/koha # dev install (or another path ofc, the one in the intranetdir config) Weird thing: * debian/scripts/koha-plack 392 adjust_paths_dev_install $name 393 export DEV_INSTALL 394 export KOHA_HOME 395 PERL5LIB=$PERL5LIB:$KOHA_HOME/installer:$KOHA_HOME/lib/installer On a pkg install we don't have /usr/share/koha/installer or /usr/share/koha/lib/installer On a dev instal we don't have /kohadevbox/koha/lib Created attachment 105552 [details] [review] Bug 25586: (bug 25618 follow-up) Use KOHA_HOME to guess pkg bin dir I was wondering what KOHA_HOME was about yesterday... Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is unset. Then in kohadevbox and koha-testing-docker, an environmental variable can be set to a dev install location? Created attachment 105573 [details] [review] Bug 25586: (bug 25618 follow-up) Use KOHA_HOME to guess pkg bin dir Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> (In reply to David Cook from comment #4) > I was wondering what KOHA_HOME was about yesterday... > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is > unset. > > Then in kohadevbox and koha-testing-docker, an environmental variable can be > set to a dev install location? We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think adding more variables will help. KOHA_HOME is the place where intranetdir code is placed, I got this with grep:
> koha-functions.sh: KOHA_HOME=$(run_safe_xmlstarlet $instancename intranetdir)
So using KOHA_HOME is favourable in my opinion to be able to support installations with different installation paths. The user should be able to change only the paths in koha-conf.xml and stuff should work, now without this variable things don't work so the original patch should be extended to include also koha-plack and maybe other scripts.
(In reply to Jonathan Druart from comment #6) > (In reply to David Cook from comment #4) > > I was wondering what KOHA_HOME was about yesterday... > > > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is > > unset. > > > > Then in kohadevbox and koha-testing-docker, an environmental variable can be > > set to a dev install location? > > We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think > adding more variables will help. This is not a new variable. (In reply to Marcel de Rooy from comment #8) > (In reply to Jonathan Druart from comment #6) > > (In reply to David Cook from comment #4) > > > I was wondering what KOHA_HOME was about yesterday... > > > > > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is > > > unset. > > > > > > Then in kohadevbox and koha-testing-docker, an environmental variable can be > > > set to a dev install location? > > > > We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think > > adding more variables will help. > > This is not a new variable. KOHA_HOME is not (hence this bug report). David's suggestion was to add a new one. At least it's what I understood. (In reply to Jonathan Druart from comment #9) > (In reply to Marcel de Rooy from comment #8) > > (In reply to Jonathan Druart from comment #6) > > > (In reply to David Cook from comment #4) > > > > I was wondering what KOHA_HOME was about yesterday... > > > > > > > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is > > > > unset. > > > > > > > > Then in kohadevbox and koha-testing-docker, an environmental variable can be > > > > set to a dev install location? > > > > > > We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think > > > adding more variables will help. > > > > This is not a new variable. > > KOHA_HOME is not (hence this bug report). David's suggestion was to add a > new one. At least it's what I understood. I think you misunderstood me, Jonathan. I meant keeping the existing KOHA_HOME variable, but setting it differently (to make it easier to re-configure for dev environments and when using systemd services). |