Summary: | Street number is missing from alternate address in the OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | David Roberts <david.roberts> |
Component: | OPAC | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
Circulation function: | |||
Attachments: |
Bug 25590: B_streetnumber is missing from opac-memberentry.pl
Bug 25590: B_streetnumber is missing from opac-memberentry.pl Bug 25590: Street number is missing from the alternate address in the OPAC Bug 25590: Street number is missing from the alternate address in the OPAC Bug 25590: Street number is missing from the alternate address in the OPAC |
Description
David Roberts
2020-05-22 21:00:02 UTC
Created attachment 105283 [details] [review] Bug 25590: B_streetnumber is missing from opac-memberentry.pl This patch adds the ability to add / edit the street number field (B_streetnumber) in the Alternate address area of the patron record on the OPAC. To test: 1) Check that you are unable to add a street number to the Alternate address record when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Check that it works with the field set to be mandatory as well as non-mandatory Created attachment 105284 [details] [review] Bug 25590: B_streetnumber is missing from opac-memberentry.pl This patch adds the ability to add / edit the street number field (B_streetnumber) in the Alternate address area of the patron record on the OPAC. To test: 1) Check that you are unable to add a street number to the Alternate address record when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Check that it works with the field set to be mandatory as well as non-mandatory Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Hi David, the sequence of fields is not right when AddressFormat = German is selected. That's because we put the street number after the street name here. If you check how this is handled for the Main address, I think this could be copied for the Alternate address without too much headache. Another thing, but more for dicussion: Should we amend the *unwanted* preferences to add B_streetnumber on update to avoid behavior change? Looking at bug 32663, I realized this is still valid. Maybe time to have another look. Hope it's ok, I am stealing this one with a new patch. Created attachment 147422 [details] [review] Bug 25590: Street number is missing from the alternate address in the OPAC This patch adds the street number field to the alternate address section in the OPAC, matching the layout of the address in the staff interface. To test: 1) Check that you are unable to add a street number to the Alternate address when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Make the field mandatory and verify this works as expected (PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerMandatoryField) 6) Hide the field from the form (PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField) 7) Change the AddressFormat system preference to German 8) Verify that the street number field moved after the first address line matching the first address in the form. Created attachment 147438 [details] [review] Bug 25590: Street number is missing from the alternate address in the OPAC This patch adds the street number field to the alternate address section in the OPAC, matching the layout of the address in the staff interface. To test: 1) Check that you are unable to add a street number to the Alternate address when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Make the field mandatory and verify this works as expected (PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerMandatoryField) 6) Hide the field from the form (PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField) 7) Change the AddressFormat system preference to German 8) Verify that the street number field moved after the first address line matching the first address in the form. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 148243 [details] [review] Bug 25590: Street number is missing from the alternate address in the OPAC This patch adds the street number field to the alternate address section in the OPAC, matching the layout of the address in the staff interface. To test: 1) Check that you are unable to add a street number to the Alternate address when logged into the OPAC 2) Apply the patch 3) Check that you can now add and edit the streetnumber field. 4) Check that it also works correctly in patron self-registration. 5) Make the field mandatory and verify this works as expected (PatronSelfRegistrationBorrowerMandatoryField and PatronSelfModificationBorrowerMandatoryField) 6) Hide the field from the form (PatronSelfRegistrationBorrowerUnwantedField and PatronSelfModificationBorrowerUnwantedField) 7) Change the AddressFormat system preference to German 8) Verify that the street number field moved after the first address line matching the first address in the form. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Great to see this taken care of :) Passing QA Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |