Summary: | Error when unsetting default checkout, hold and return policy for a specific library | ||
---|---|---|---|
Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | major | ||
Priority: | P5 - low | CC: | aleisha, gmcharlt, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.07
|
|
Circulation function: | |||
Bug Depends on: | 18928 | ||
Bug Blocks: | |||
Attachments: |
Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch"
Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch" Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch" |
Description
Victor Grousset/tuxayo
2020-05-26 04:35:15 UTC
Workaround: empty the fields and set the lists to the default value and save instead of using the unset button. It looks like a regression, I couldn't reproduce on 4 different demo instances running version 19.11 Setting severity to major (I don't know how actually bad this bug is) Created attachment 105348 [details] [review] Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch" returnbranch has to pass an itemtype key when setting the rule (here setting it to unlimited for any item types) Test plan: 1. Go the "Circulation and fine rules" admin page 2. Set a rule for "Checkout, hold policy by patron category" 3. Unset it 4. Select a library 5. Set a rule for "Checkout, hold policy by patron category" 6. Unset it Display should be consistent with what you selected Created attachment 105372 [details] [review] Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch" returnbranch has to pass an itemtype key when setting the rule (here setting it to unlimited for any item types) Test plan: 1. Go the "Circulation and fine rules" admin page 2. Set a rule for "Default checkout, hold and return policy" 3. Unset it 4. Select a library 5. Set a rule for "Default checkout, hold and return policy" 6. Unset it Display should be consistent with what you selected Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> > 2. Set a rule for "Checkout, hold policy by patron category"
You meant "Default checkout, hold and return policy" right?
Assumed yes, test plan was changed.
(In reply to Victor Grousset/tuxayo from comment #5) > > 2. Set a rule for "Checkout, hold policy by patron category" > > You meant "Default checkout, hold and return policy" right? > > Assumed yes, test plan was changed. Yes, I c/p the wrong header! Created attachment 105392 [details] [review] Bug 25601: (bug 18928 follow-up) Fix "Unset" for "return policy for $branch" returnbranch has to pass an itemtype key when setting the rule (here setting it to unlimited for any item types) Test plan: 1. Go the "Circulation and fine rules" admin page 2. Set a rule for "Default checkout, hold and return policy" 3. Unset it 4. Select a library 5. Set a rule for "Default checkout, hold and return policy" 6. Unset it Display should be consistent with what you selected Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 20.05 backported to 19.11.x for 19.11.07 No need to backport to 19.05.x, it's not affected by this bug. |