| Summary: | (regression) Inventory is broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Didier Gautheron <didier.gautheron> |
| Component: | Architecture, internals, and plumbing | Assignee: | Didier Gautheron <didier.gautheron> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | aleisha, jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05
|
|
| Circulation function: | |||
| Bug Depends on: | 23463 | ||
| Bug Blocks: | 25167 | ||
| Attachments: |
Bug 25608: Regression - Bug 23463 broke inventory
Bug 25608: (bug 23463 follow-up) Fix inventory regression Bug 25608: (bug 23463 follow-up) Fix inventory regression |
||
Created attachment 105373 [details] [review] Bug 25608: Regression - Bug 23463 broke inventory Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Submit => without patch, you get an error trace - Apply patch, it works Caused by commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store Created attachment 105377 [details] [review] Bug 25608: (bug 23463 follow-up) Fix inventory regression Follow-up work commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Submit => without patch, you get an error trace - Apply patch, it works Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended commit title. Created attachment 105391 [details] [review] Bug 25608: (bug 23463 follow-up) Fix inventory regression Follow-up work commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Submit => without patch, you get an error trace - Apply patch, it works Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended commit title. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 20.05 missing dependencies, not backported to 19.11.x |
need to use unblessed items. Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Check ' - Submit => without patch, you get an error trace Error trace Can't call method "title" on an undefined value at /kohadevbox/koha/tools/inventory.pl line 347, <$fh> line 2. at /kohadevbox/koha/tools/inventory.pl line 347 in (eval) at /kohadevbox/koha/tools/inventory.pl line 347 344: : $inventorylist // []; 345: for my $item ( @$loop ) { 346: my $biblio = Koha::Biblios->find( $item->{biblionumber} ); 347: $item->{title} = $biblio->title; 348: $item->{author} = $biblio->author; 349: } 350: