Summary: | Changing the vendor when creating the basket does not keep that new vendor | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, jonathan.druart, julian.maurice, lucas, rkuiper, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.11.00, 20.05.02, 19.11.08, 19.05.14
|
Circulation function: | |
Bug Depends on: | 7757 | ||
Bug Blocks: | |||
Attachments: |
Bug 25611: Use selected vendor when creating a basket
Bug 25611: Use selected vendor when creating a basket Bug 25611: Use selected vendor when creating a basket Bug 25611: Use selected vendor when creating a basket |
Description
Kelly McElligott
2020-05-27 18:00:47 UTC
Looks like a super old bug, good catch! Created attachment 105572 [details] [review] Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Created attachment 105891 [details] [review] Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Created attachment 105929 [details] [review] Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Created attachment 106100 [details] [review] Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor Reported-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Rhonda Kuiper <rkuiper@roundrocktexas.gov> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> It's strange that we can change the vendor when the page title says "Create new basket for <Vendor>" (and the title is not updated when we select another vendor), but the patch does fix a bug. Passed QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.02 backported to 19.11.x for 19.11.08 Backported to 19.05.x branch for 19.05.14 |