Summary: | Empty select in "Holds to pull" filters | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, lucas, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.01, 19.11.07, 19.05.13
|
|
Bug Depends on: | 22536 | ||
Bug Blocks: | |||
Attachments: |
Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull"
Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" |
Description
Jonathan Druart
2020-05-28 10:11:20 UTC
Created attachment 105406 [details] [review] Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" On the "Holds to pull" view there are filters that are built on the value of the cells. Bug 22536 improved the ergonomic by adding a ul list, but the filters are now broken, the ul and li tags are retrieved and put in the filter list. The idea of this patch is to remove the HTML tags and skip if the value is then empty. Test plan: Place a hold on an item Go to Home › Circulation › Holds to pull Open the "libraries" filter => Without this patch you see empty entries => With this patch the filter contain only the libraries And, of course, make sure the filter works! Created attachment 105407 [details] [review] Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" On the "Holds to pull" view there are filters that are built on the value of the cells. Bug 22536 improved the ergonomic by adding a ul list, but the filters are now broken, the ul and li tags are retrieved and put in the filter list. The idea of this patch is to remove the HTML tags and skip if the value is then empty. Test plan: Place a hold on an item Go to Home › Circulation › Holds to pull Open the "libraries" filter => Without this patch you see empty entries => With this patch the filter contain only the libraries Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 105410 [details] [review] Bug 25615: Remove empty entries in the filter dropdowns of "holds to pull" On the "Holds to pull" view there are filters that are built on the value of the cells. Bug 22536 improved the ergonomic by adding a ul list, but the filters are now broken, the ul and li tags are retrieved and put in the filter list. The idea of this patch is to remove the HTML tags and skip if the value is then empty. Test plan: Place a hold on an item Go to Home › Circulation › Holds to pull Open the "libraries" filter => Without this patch you see empty entries => With this patch the filter contain only the libraries Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.01 backported to 19.11.x for 19.11.07 Backported to 19.05.x branch for 19.05.13 |