Summary: | Koha/XSLT/Base.t is failing on U20 | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, dcook, lucas, m.de.rooy, mtj, tomascohen, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.11.00, 20.05.01, 19.11.09, 19.05.15
|
Circulation function: | |
Bug Depends on: | |||
Bug Blocks: | 25640 | ||
Attachments: |
Bug 25641: Fix Koha/XSLT/Base.t failures on U20
Bug 25641: Fix Koha/XSLT/Base.t failures on U20 Bug 25641: [19.11.x] Fix XSLT_Handler.t failures on U20 |
Description
Jonathan Druart
2020-06-01 10:53:31 UTC
Created attachment 105469 [details] [review] Bug 25641: Fix Koha/XSLT/Base.t failures on U20 There is a change in the version number. On U20 we get Opening and ending tag mismatch: a line 0 and b On others (D9, D10, U18) we get: Opening and ending tag mismatch: a line 1 and b I did not find where it did come from, so assuming it's just a minor change and won't have side-effects. Test plan: Make sure the tests pass on U20 and another OS (In reply to Jonathan Druart from comment #1) > Created attachment 105469 [details] [review] [review] > Bug 25641: Fix Koha/XSLT/Base.t failures on U20 > > There is a change in the version number. > On U20 we get > Opening and ending tag mismatch: a line 0 and b > On others (D9, D10, U18) we get: > Opening and ending tag mismatch: a line 1 and b > > I did not find where it did come from, so assuming it's just a minor > change and won't have side-effects. > > Test plan: > Make sure the tests pass on U20 and another OS hi, i've seen the same error on deb11 too https://jenkins.koha-community.org/job/Koha_Master_D11/2/ https://jenkins.koha-community.org/job/Koha_Master_D11/2/testReport/junit/(root)/t_db_dependent_Koha_XSLT_Base_t/Malformed_XML_warning_correctly_displayed__2075_/ not ok 10 - Malformed XML warning correctly displayed ok 11 - Engine returns error on malformed xml not ok 12 - Malformed XML warning correctly displayed ok 13 - Engine respects do_not_return_source==1 not ok 14 - Malformed XML warning correctly displayed ok 15 - Second engine respects it too not ok 16 - Malformed XML warning correctly displayed Created attachment 105606 [details] [review] Bug 25641: Fix Koha/XSLT/Base.t failures on U20 There is a change in the version number. On U20 we get Opening and ending tag mismatch: a line 0 and b On others (D9, D10, U18) we get: Opening and ending tag mismatch: a line 1 and b I did not find where it did come from, so assuming it's just a minor change and won't have side-effects. Test plan: Make sure the tests pass on U20 and another OS Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> It works! (U20, D10, D11) Skipping QA, I want this one pushed. Pushed to master for 20.11, thanks to everybody involved! Is U20 counting lines in a file from 0 now ? Maybe we should just use \d+ ? The line number is not really relevant.. That's how I fixed it at the beginning. But then it sounded more accurate to test 0|1. backported to 20.05.x for 20.05.01 t/db_dependent/Koha/XSLT/Base.t is not in 19.11.x, not backporting Created attachment 108622 [details] [review] Bug 25641: [19.11.x] Fix XSLT_Handler.t failures on U20 (In reply to Aleisha Amohia from comment #10) > t/db_dependent/Koha/XSLT/Base.t is not in 19.11.x, not backporting This test was failing on Koha_19.11_U20 #59 Here is a patch for 19.11.x backported second patch to 19.11.x for 19.11.09 Backported to 19.05.x branch for 19.05.15 |