| Summary: | Add location and itype descriptions in ILS-DI GetRecords | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Web services | Assignee: | Julian Maurice <julian.maurice> |
| Status: | CLOSED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | dcook, lucas, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 32996 | ||
| Attachments: |
Bug 25650: Add location and itype descriptions in ILS-DI GetRecords
Bug 25650: Add location and itype descriptions in ILS-DI GetRecords Bug 25650: Add location and itype descriptions in ILS-DI GetRecords |
||
|
Description
Julian Maurice
2020-06-02 07:46:27 UTC
Created attachment 105480 [details] [review] Bug 25650: Add location and itype descriptions in ILS-DI GetRecords Test plan: 1. Create a record with an item, and set the item's shelving location and itemtype. 2. Go to http://<OPAC>/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=<biblionumber> 3. Check that there is <itype_description> and <location_description> and that their value is correct. Created attachment 107087 [details] [review] Bug 25650: Add location and itype descriptions in ILS-DI GetRecords Test plan: 1. Create a record with an item, and set the item's shelving location and itemtype. 2. Go to http://<OPAC>/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=<biblionumber> 3. Check that there is <itype_description> and <location_description> and that their value is correct. Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Since Julian and Arthur are both from BibLibre, this should probably be reset to "Needs Signoff". Created attachment 107932 [details] [review] Bug 25650: Add location and itype descriptions in ILS-DI GetRecords Test plan: 1. Create a record with an item, and set the item's shelving location and itemtype. 2. Go to http://<OPAC>/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=<biblionumber> 3. Check that there is <itype_description> and <location_description> and that their value is correct. Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> This works as described. I have a question: for homebrnahcname and holdingbranchname we include the key whether or not we have a value - here the description tags are not included if the itype of location don't match an existing value - is there a reason for this? (In reply to Nick Clemens from comment #5) > This works as described. > > I have a question: for homebrnahcname and holdingbranchname we include the > key whether or not we have a value - here the description tags are not > included if the itype of location don't match an existing value - is there a > reason for this? Julian, can you please check and comment? (In reply to Nick Clemens from comment #5) > This works as described. > > I have a question: for homebrnahcname and holdingbranchname we include the > key whether or not we have a value - here the description tags are not > included if the itype of location don't match an existing value - is there a > reason for this? No specific reason. It just seems useless to add an empty element. There is also the 'transfer' element which is not added unless there is a transfer. Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |