Bug 25652

Summary: Holds daily is not looking at item type when not allowing holds
Product: Koha Reporter: Kelly McElligott <kelly>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: catrina, gmcharlt, hebah, sbrown, tech, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15486    
Bug Blocks:    

Description Kelly McElligott 2020-06-02 13:07:34 UTC
If a library has a rule that allows 5 holds daily on DVDs and 50 holds daily on the BOOK rule, Koha will count the first 5 holds regardless of item type and not allow any more of that item type (DVD)  for a hold, but will allow more BOOK holds. 




 423     my $today_holds = Koha::Holds->search({
 424         borrowernumber => $borrowernumber,
 425         reservedate    => dt_from_string->date
 426     });


Koha should be looking at Item Type when determining whether a hold can be placed in this today_holds search.
Comment 1 Katrin Fischer 2020-06-11 20:35:44 UTC
This reads like a bug - updating.
Comment 2 Eric Swenson 2020-11-06 14:41:10 UTC
Hi there! Salina Public Library chiming in. We stumbled into this issue as well, so it would be very nice for this functionality to work. We have begun to increase the amount of holds people can place on items but as a way to help out our circulation department the ability to limit the number of holds per day would be nice.
Comment 3 Sara Brown 2022-08-15 20:53:22 UTC
This is still relevant as of 21.11.05. Being able to use the feature with the accurate per-item type limit would be very helpful!
Comment 4 Katrin Fischer 2022-08-21 21:07:13 UTC
I think it might not be easy to implement or maybe only with a fallback to the record level itemtype.

When a hold is placed without being limited to an item type, it's not easy to determine which itemtype should apply if there are multiple items that could fill the hold with different itemtypes.
Comment 5 Catrina Berka 2022-09-22 20:15:01 UTC
Perhaps we should consider deleting this column from the table. Its location is misleading.
Comment 6 Katrin Fischer 2024-01-01 09:39:58 UTC
(In reply to Catrina Berka from comment #5)
> Perhaps we should consider deleting this column from the table. Its location
> is misleading.

Can you explain what you mean a bit more?