Summary: | Print icon sometimes obscures patron barcode | ||
---|---|---|---|
Product: | Koha | Reporter: | Benjamin Daeuber <bdaeuber> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Alex Arnaud <alex.arnaud> |
Severity: | minor | ||
Priority: | P5 - low | CC: | aleisha, alex.arnaud, gmcharlt, jonathan.druart, kyle.m.hall, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.01
|
|
Circulation function: | |||
Bug Depends on: | 17854 | ||
Bug Blocks: | |||
Attachments: |
screenshot of the print button covering the patron information
Bug 25658: Print icon sometimes obscures patron barcode Bug 25658: Print icon sometimes obscures patron barcode Bug 25658: Print icon sometimes obscures patron barcode |
Where does come from this print icon? (In reply to Jonathan Druart from comment #1) > Where does come from this print icon? It was introduced in 19.05 with the DisplayClearScreenButton system preference. Created attachment 105560 [details] [review] Bug 25658: Print icon sometimes obscures patron barcode This patch alters the style of the patron name/cardnumber label on the checkout screen so that it has a maximum width. This will help avoid the label being obscured by the print/close buttons displayed when DisplayClearScreenButton is enabled. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the DisplayClearScreenButton system preference. - Check out to a patron. Resize the browser to confirm that at narrower browser widths the patron name in the checkout form isn't obscured by the print and clear screen buttons. Created attachment 105617 [details] [review] Bug 25658: Print icon sometimes obscures patron barcode This patch alters the style of the patron name/cardnumber label on the checkout screen so that it has a maximum width. This will help avoid the label being obscured by the print/close buttons displayed when DisplayClearScreenButton is enabled. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the DisplayClearScreenButton system preference. - Check out to a patron. Resize the browser to confirm that at narrower browser widths the patron name in the checkout form isn't obscured by the print and clear screen buttons. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 105778 [details] [review] Bug 25658: Print icon sometimes obscures patron barcode This patch alters the style of the patron name/cardnumber label on the checkout screen so that it has a maximum width. This will help avoid the label being obscured by the print/close buttons displayed when DisplayClearScreenButton is enabled. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the DisplayClearScreenButton system preference. - Check out to a patron. Resize the browser to confirm that at narrower browser widths the patron name in the checkout form isn't obscured by the print and clear screen buttons. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.01 patches do not apply cleanly, please rebase if needed on 19.11.x |
Created attachment 105499 [details] screenshot of the print button covering the patron information On circulation.pl, the print icon in the checkout box can sometimes obscure the patron's barcode. Making the window a slightly different size can address this, but that' sometimes not an option. I am attaching a screenshot. This is taken from Chrome 83, but I can confirm it's occurring in Firefox as well.