Bug 25696

Summary: Test prediction pattern button is invalid HTML
Product: Koha Reporter: David Cook <dcook>
Component: SerialsAssignee: David Cook <dcook>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: aleisha, colin.campbell, jonathan.druart, lucas, victor
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.01, 19.11.07, 19.05.13
Bug Depends on: 22408    
Bug Blocks:    
Attachments: Bug 25696: Correct "Test prediction pattern" HTML button
Bug 25696: Correct "Test prediction pattern" HTML button

Description David Cook 2020-06-09 05:03:02 UTC
It looks like the "Test prediction pattern" button is invalid HTML. Browsers like Chrome just fix it, but IE 11 complains about it.
Comment 1 David Cook 2020-06-09 06:07:56 UTC
Created attachment 105654 [details] [review]
Bug 25696: Correct "Test prediction pattern" HTML button

This patch corrects the closing tag for the "Test prediction pattern"
button from "</a>" to "</button>"

Test plan:
1. Apply the patch
2. Create a serial subscription from a new or existing bib record
3. Choose any frequency, numbering pattern, and subscription start
date you choose (ie fill out all mandatory subscription fields)
4. Click "Test prediction pattern"
5. Note that the prediction pattern appears on the right of the screen
Comment 2 Katrin Fischer 2020-06-11 19:23:50 UTC
Created attachment 105773 [details] [review]
Bug 25696: Correct "Test prediction pattern" HTML button

This patch corrects the closing tag for the "Test prediction pattern"
button from "</a>" to "</button>"

Test plan:
1. Apply the patch
2. Create a serial subscription from a new or existing bib record
3. Choose any frequency, numbering pattern, and subscription start
date you choose (ie fill out all mandatory subscription fields)
4. Click "Test prediction pattern"
5. Note that the prediction pattern appears on the right of the screen

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2020-06-11 19:24:32 UTC
Obvious one line fix - switching to PQA.
Comment 4 Jonathan Druart 2020-06-15 10:01:06 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 5 Lucas Gass 2020-06-17 22:48:07 UTC
backported to 20.05.x for 20.05.01
Comment 6 Aleisha Amohia 2020-06-22 03:23:54 UTC
backported to 19.11.x for 19.11.07
Comment 7 Victor Grousset/tuxayo 2020-07-02 23:19:29 UTC
Backported to 19.05.x branch for 19.05.13