Summary: | Add edition information to Holds to pull report | ||
---|---|---|---|
Product: | Koha | Reporter: | Minna Kivinen <minna.kivinen> |
Component: | Circulation | Assignee: | Peter Vashchuk <stalkernoid> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, gmcharlt, kyle.m.hall, lucas, nugged, slavashishkin, stalkernoid |
Version: | 20.05 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.02
|
|
Circulation function: | |||
Attachments: |
Bug 25699: Add edition information to "Holds to pull" report
Bug 25699: Add edition information to "Holds to pull" report Bug 25699: Add edition information to "Holds to pull" report Bug 25699: Add edition information to "Holds to pull" report |
Description
Minna Kivinen
2020-06-09 07:13:02 UTC
Created attachment 105691 [details] [review] Bug 25699: Add edition information to "Holds to pull" report Added a feature that displays edition information of the book together with title in "Holds to pull" report. Edition information is fetched from "biblioitem" table as "editionstatement" and transferred to template. Those changes don't have performance impact because all tables including "biblioitem" were already used and joined in this request. Mentored-by: Andrew Nugged <nugged@gmail.com> Created attachment 105786 [details] [review] Bug 25699: Add edition information to "Holds to pull" report Added a feature that displays edition information of the book together with title in "Holds to pull" report. Edition information is fetched from "biblioitem" table as "editionstatement" and transferred to template. Those changes don't have performance impact as all tables including "biblioitem" were already used and joined in this request. Mentored-by: Andrew Nugged <nugged@gmail.com> Created attachment 106006 [details] [review] Bug 25699: Add edition information to "Holds to pull" report Added a feature that displays edition information of the book together with title in "Holds to pull" report. Edition information is fetched from "biblioitem" table as "editionstatement" and transferred to template. Those changes don't have performance impact as all tables including "biblioitem" were already used and joined in this request. Mentored-by: Andrew Nugged <nugged@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Hi Petro, thx for the patch! You've got a good description of the patch in your commit message, but it would be nice to also have steps for testing this. Not an issue here for me, just noting for future patches! I also suspect you might not be using git-bz yet (from the [PATCH] in your subject line) - if not, I recommend checking it out as it makes life a lot easier. Created attachment 106132 [details] [review] Bug 25699: Add edition information to "Holds to pull" report Added a feature that displays edition information of the book together with title in "Holds to pull" report. Edition information is fetched from "biblioitem" table as "editionstatement" and transferred to template. Those changes don't have performance impact as all tables including "biblioitem" were already used and joined in this request. Mentored-by: Andrew Nugged <nugged@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> *** Bug 25799 has been marked as a duplicate of this bug. *** (In reply to Katrin Fischer from comment #4) > but it would be nice to also have steps for testing this. all three of us noted that, ok, thanks :P. Pushed to master for 20.11, thanks to everybody involved! useful enhancement, choosing to backport backported to 20.05.x for 20.05.02 enhancement, not backporting to 19.11.x |