Description
Martin Renvoize (ashimema)
2020-06-09 10:31:33 UTC
Created attachment 112113 [details] [review] Bug 25700 - Complete KohCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppress dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates are correct - links to Koha website ou wiki are correct Created attachment 112115 [details] [review] Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Created attachment 112144 [details] [review] Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 112145 [details] [review] Bug 25700: (follow-up) Minor corrections to epoch dates It looks like we forgot to account for the year change when grabbing epoch dates for some of the later KohaCon's. This patch fixes those minor mistakes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Great work Séverine, I fixed a minor typo in the first line whilst signing off ad added a tiny followup to correct some epoch dates.. I think you forgot to change the year when entering dates to get epoch times back ;) Looks great and nice and consistent, thanks! "workshop" in Dublin and "hackfest" in Wellington, why this choice? At KohaCon20 they use "workshop" https://2020.kohacon.org/posts/programme/ If I remember well, there was no hackfest in Dublin. Workshops were organised for all KohaCons for what I saw. But you're right, it might be confusing. Do you prefer to mention workshops for all the KohaCons, like "KohaconXX, worshops and Hackfest in XXX" ? Created attachment 112173 [details] [review] Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 112174 [details] [review] Bug 25700: (follow-up) Minor corrections to epoch dates It looks like we forgot to account for the year change when grabbing epoch dates for some of the later KohaCon's. This patch fixes those minor mistakes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Jonathan Druart from comment #6) > "workshop" in Dublin and "hackfest" in Wellington, why this choice? > > At KohaCon20 they use "workshop" > https://2020.kohacon.org/posts/programme Good catch, At KohaCon19 we chose to rename the 'Hackfest' to 'Workshops' as a bit of a re-branding to get more librarians and non-developers involved.. I think KohaCon20 took the same approach? So, I would say pre 19 Hackfest is the right name, post 19 Workshops is correct. (In reply to Séverine Queune from comment #7) > If I remember well, there was no hackfest in Dublin. > Workshops were organised for all KohaCons for what I saw. > But you're right, it might be confusing. > Do you prefer to mention workshops for all the KohaCons, like "KohaconXX, > worshops and Hackfest in XXX" ? I would use "workshops" for 19 and 20. Also, KohaCon11 wiki link does notwork. Thanks Jonathan for feedback ! I've been a bit annoyed by this KohaCon11, for the official website is now closed and I didn't find a page with relevant informations about it. Is that one ok for you ? https://koha-community.org/category/kohacon-2011/ Created attachment 112729 [details] [review] Bug 25700: (follow-up 2) 2 minor corrections for KohaCon This patch corrects : - the wrong link for KohaCon11 - a typo on 'workshops' for KohaCon19 - replace 'hackfest' for 'workshops' for KohaCon20 First time I do a follow-up, I hope I did it well. Already spoted a typo on the patch's title (2 instead of 3), I hope it's the only one... Created attachment 112784 [details] [review] Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 112785 [details] [review] Bug 25700: (follow-up) Minor corrections to epoch dates It looks like we forgot to account for the year change when grabbing epoch dates for some of the later KohaCon's. This patch fixes those minor mistakes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 112786 [details] [review] Bug 25700: (follow-up 2) 2 minor corrections for KohaCon This patch corrects : - the wrong link for KohaCon11 - a typo on 'workshops' for KohaCon19 - replace 'hackfest' for 'workshops' for KohaCon20 Signed-off-by: David Nind <david@davidnind.com> Created attachment 112788 [details] [review] Bug 25700: Complete KohaCons informations in timeline Last entry for KohaCons on Koha timeline was for 2013. This patch : - adds KohaCons from 2014 to 2020 - adds missing link to KohaCons websites for events from 2006 to 2013 - suppresses dead links for old KohaCons - standardizes the display of informations To test, apply patch and check : - there is no typo (especially for October > Octobre) - order of dates is correct - links to Koha website ou wiki are correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 112789 [details] [review] Bug 25700: (follow-up) Minor corrections to epoch dates It looks like we forgot to account for the year change when grabbing epoch dates for some of the later KohaCon's. This patch fixes those minor mistakes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 112790 [details] [review] Bug 25700: (follow-up) 2 minor corrections for KohaCon This patch corrects : - the wrong link for KohaCon11 - a typo on 'workshops' for KohaCon19 - replace 'hackfest' for 'workshops' for KohaCon20 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! |