|
Description
Martin Renvoize (ashimema)
2020-06-15 15:02:19 UTC
Created attachment 105900 [details] [review] Bug 25757: Add item relation to Koha::Item::Transfer Created attachment 105901 [details] [review] Bug 25757: Add Koha::Item::Transfer->transit method Created attachment 105902 [details] [review] Bug 25757: Add unit tests for item relation Created attachment 107241 [details] [review] Bug 25757: Add item relation to Koha::Item::Transfer Created attachment 107242 [details] [review] Bug 25757: Add Koha::Item::Transfer->transit method Created attachment 107243 [details] [review] Bug 25757: Add unit tests for item relation Test plan 1/ Run the included unit tests and verify they pass Created attachment 107296 [details] [review] Bug 25757: Add item relation to Koha::Item::Transfer Created attachment 107297 [details] [review] Bug 25757: Add Koha::Item::Transfer->transit method Created attachment 107298 [details] [review] Bug 25757: Add unit tests for item relation Created attachment 110274 [details] [review] Bug 25757: Add item relation to Koha::Item::Transfer Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Created attachment 110275 [details] [review] Bug 25757: Add Koha::Item::Transfer->transit method Test plan 1/ Run the included unit tests Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Created attachment 110276 [details] [review] Bug 25757: Add unit tests for item relation Test plan 1/ Run the unit test Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Tested in use by Kathleen as part of relying on bug 22569 Created attachment 110296 [details] [review] Bug 25757: Add item relation to Koha::Item::Transfer Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110297 [details] [review] Bug 25757: Add Koha::Item::Transfer->transit method Test plan 1/ Run the included unit tests Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110298 [details] [review] Bug 25757: Add unit tests for item relation Test plan 1/ Run the unit test Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Giving these patches my QA stamp, but setting to BLOCKED as we need to resolve the questions on the dependent bug first. Created attachment 110507 [details] [review] Bug 25757: Add item relation to Koha::Item::Transfer Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110508 [details] [review] Bug 25757: Add Koha::Item::Transfer->transit method Test plan 1/ Run the included unit tests Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110509 [details] [review] Bug 25757: Add unit tests for item relation Test plan 1/ Run the unit test Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 116547 [details] [review] Bug 25757: Add item relation to Koha::Item::Transfer Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 116548 [details] [review] Bug 25757: Add Koha::Item::Transfer->transit method Test plan 1/ Run the included unit tests Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 116549 [details] [review] Bug 25757: Add unit tests for item relation Test plan 1/ Run the unit test Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> + # Remove the 'shelving cart' location status if it is being used (Bug 3701) + CartToShelf( $self->item->itemnumber ) + if $self->item->location + && $self->item->location eq 'CART' + && (!$self->item->permanent_location + || $self->item->permanent_location ne 'CART' ); We have this code on several places. Willing to move them to a dedicated Koha::Item method? (on its own bug report ofc) Created attachment 117580 [details] [review] Bug 25757: Add item relation to Koha::Item::Transfer Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 117581 [details] [review] Bug 25757: Add Koha::Item::Transfer->transit method Test plan 1/ Run the included unit tests Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 117582 [details] [review] Bug 25757: Add unit tests for item relation Test plan 1/ Run the unit test Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |