|
Description
Martin Renvoize (ashimema)
2020-06-16 11:06:05 UTC
Created attachment 105905 [details] [review] Bug 25767: Add Koha::Item::Transfer->receipt method Created attachment 105906 [details] [review] Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Created attachment 107244 [details] [review] Bug 25767: Add Koha::Item::Transfer->receipt method Created attachment 107245 [details] [review] Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Test plan 1/ Run the included unit tests and verify they pass Created attachment 107299 [details] [review] Bug 25767: Add Koha::Item::Transfer->receipt method Created attachment 107300 [details] [review] Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Created attachment 110277 [details] [review] Bug 25767: Add Koha::Item::Transfer->receipt method Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Created attachment 110278 [details] [review] Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Tested in use by Kathleen as part of relying on bug 22569 Created attachment 110299 [details] [review] Bug 25767: Add Koha::Item::Transfer->receipt method Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110300 [details] [review] Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Blocked by dependent bug not ready yet. Also a question: I wonder about the method name. As this is not just returning an object, but changing data receive would make a bit more sense to me than receipt (noun). What do you think? (In reply to Katrin Fischer from comment #13) > Blocked by dependent bug not ready yet. > > Also a question: I wonder about the method name. As this is not just > returning an object, but changing data receive would make a bit more sense > to me than receipt (noun). What do you think? Well.. in British English at least you can use receipt as both a noun and a verb.. noun 1. a document acknowledging that a person has received money or property in payment following a sale or other transfer of goods or provision of a service verb 1. the action of receiving something or the fact of its being received. 2. to mark (a bill) as paid. But I do see your point and perhaps receive is more in keeping with other terms in Koha already, and will be more internationally understood. Created attachment 110397 [details] [review] Bug 25767: Add Koha::Item::Transfer->receipt method Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110398 [details] [review] Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110399 [details] [review] Bug 25767: (QA follow-up) receipt -> receive Created attachment 110510 [details] [review] Bug 25767: Add Koha::Item::Transfer->receipt method Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110511 [details] [review] Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 110512 [details] [review] Bug 25767: (QA follow-up) receipt -> receive Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 116550 [details] [review] Bug 25767: Add Koha::Item::Transfer->receipt method Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 116551 [details] [review] Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 116552 [details] [review] Bug 25767: (QA follow-up) receipt -> receive Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 117571 [details] [review] Bug 25767: Add Koha::Item::Transfer->receive method Was Bug 25767: Add Koha::Item::Transfer->receipt method Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Bug 25767: (QA follow-up) receipt -> receive Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Created attachment 117583 [details] [review] Bug 25767: Add Koha::Item::Transfer->receive method Was Bug 25767: Add Koha::Item::Transfer->receipt method Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Bug 25767: Add unit tests for Koha::Item::Transfer->receipt Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Bug 25767: (QA follow-up) receipt -> receive Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Pushed to master for 21.05, thanks to everybody involved! Enhancement not pushed to 20.11.x |