|
Description
Donna
2020-06-16 19:58:22 UTC
+1 +1 This would be a fantastic addition, however if I could throw another suggestion into this request. Along with the editing date, would it be possible to log what the notice was prior to the changes? This might be helpful in having to backtrack or prove what the guts of a notice was before the change rather than having to find someone who received the notice to see what happened. I think the date field would be a great addition, however if we can keep the history that would be great. Thanks! Christofer (In reply to Christofer Zorn from comment #3) > This would be a fantastic addition, however if I could throw another > suggestion into this request. Along with the editing date, would it be > possible to log what the notice was prior to the changes? This might be > helpful in having to backtrack or prove what the guts of a notice was before > the change rather than having to find someone who received the notice to see > what happened. > > I think the date field would be a great addition, however if we can keep the > history that would be great. > > Thanks! > > Christofer Hi Christofer, there is already a bug for adding a Notices log - bug 14233. I think both things would be great to have, but better to keep them as separate features in bugzilla. Created attachment 109303 [details] [review] Bug 25776: [DO NOT PUSH] Schema update Created attachment 109304 [details] [review] Bug 25776: Add a 'last updated' column for notices This add an 'udated_on' column to the letter table and displays the information in 'slips and notices'. To test: - Apply patch - Run updatedatabase Note: the existing letters will all be set to the currnet date). - Go to Tools > Notices and slips - Verify there is a new column "Last updated" in the table Note: The table will always display the newest change date of the different message transport types. - Edit any notice - Verify the "Last updated" is shown for any transport type with an existing notice definition - Edit and add a notice - Verify the dates are correctly stored - Test the column configuration for the new column works correctly Created attachment 109305 [details] [review] Bug 25776: Add a 'last updated' column for notices This add an 'udated_on' column to the letter table and displays the information in 'slips and notices'. To test: - Apply patch - Run updatedatabase Note: the existing letters will all be set to the currnet date). - Go to Tools > Notices and slips - Verify there is a new column "Last updated" in the table Note: The table will always display the newest change date of the different message transport types. - Edit any notice - Verify the "Last updated" is shown for any transport type with an existing notice definition - Edit and add a notice - Verify the dates are correctly stored - Test the column configuration for the new column works correctly Created attachment 109382 [details] [review] Bug 25776: Add a 'last updated' column for notices This add an 'udated_on' column to the letter table and displays the information in 'slips and notices'. To test: - Apply patch - Run updatedatabase Note: the existing letters will all be set to the currnet date). - Go to Tools > Notices and slips - Verify there is a new column "Last updated" in the table Note: The table will always display the newest change date of the different message transport types. - Edit any notice - Verify the "Last updated" is shown for any transport type with an existing notice definition - Edit and add a notice - Verify the dates are correctly stored - Test the column configuration for the new column works correctly Created attachment 109383 [details]
screenshot - short not working
Katrin - love this! Everything works great, except the toggle/sort in the last updated column does not work - the notices do not get sorted by date/time. Created attachment 109384 [details] [review] Bug 25776: (follow-up) Fix sorting by change date in notices table Some markup was missing to sort the date correctly. To test: - Verify date sorting in the notices table works as expected Hi Donna, thx a lot for testing! There was definitely something missing and I hope it will work now as expected with the additional bit of code. Created attachment 110236 [details] [review] Bug 25776: [DO NOT PUSH] Schema update Signed-off-by: David Nind <david@davidnind.com> Created attachment 110237 [details] [review] Bug 25776: Add a 'last updated' column for notices This add an 'udated_on' column to the letter table and displays the information in 'slips and notices'. To test: - Apply patch - Run updatedatabase Note: the existing letters will all be set to the currnet date). - Go to Tools > Notices and slips - Verify there is a new column "Last updated" in the table Note: The table will always display the newest change date of the different message transport types. - Edit any notice - Verify the "Last updated" is shown for any transport type with an existing notice definition - Edit and add a notice - Verify the dates are correctly stored - Test the column configuration for the new column works correctly Signed-off-by: David Nind <david@davidnind.com> Created attachment 110238 [details] [review] Bug 25776: (follow-up) Fix sorting by change date in notices table Some markup was missing to sort the date correctly. To test: - Verify date sorting in the notices table works as expected Signed-off-by: David Nind <david@davidnind.com> Oh this sounds great! Created attachment 110242 [details] [review] Bug 25776: [DO NOT PUSH] Schema update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 110243 [details] [review] Bug 25776: Add a 'last updated' column for notices This add an 'udated_on' column to the letter table and displays the information in 'slips and notices'. To test: - Apply patch - Run updatedatabase Note: the existing letters will all be set to the currnet date). - Go to Tools > Notices and slips - Verify there is a new column "Last updated" in the table Note: The table will always display the newest change date of the different message transport types. - Edit any notice - Verify the "Last updated" is shown for any transport type with an existing notice definition - Edit and add a notice - Verify the dates are correctly stored - Test the column configuration for the new column works correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 110244 [details] [review] Bug 25776: (follow-up) Fix sorting by change date in notices table Some markup was missing to sort the date correctly. To test: - Verify date sorting in the notices table works as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 110245 [details] [review] Bug 25776: (QA follow-up) Add missing filter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All works well, and passes QA scripts. Passing QA Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |