Summary: | Fines can be displayed on SIP checkin/checkout | ||
---|---|---|---|
Product: | Koha | Reporter: | Matthias Meusburger <matthias.meusburger> |
Component: | SIP2 | Assignee: | Matthias Meusburger <matthias.meusburger> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, jonathan.druart, kyle, martin.renvoize, sally.healey |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00
|
|
Circulation function: | |||
Bug Depends on: | 25815 | ||
Bug Blocks: | 38073 | ||
Attachments: |
Bug 25812: Display overdue fines for the document on SIP checkin.
Bug 25812: Display overdue fines for the item on SIP checkin. Bug 25812: Display overdue fines for the item on SIP checkin. Bug 25812: Fines can be displayed on SIP checkin/checkout Bug 25812: Fines can be displayed on SIP checkin/checkout |
Description
Matthias Meusburger
2020-06-19 08:57:46 UTC
Created attachment 106056 [details] [review] Bug 25812: Display overdue fines for the document on SIP checkin. Test plan: - Using SIP, checkin an item that has one or several overdue fines. - Check that the following message is displayed (AF field): "You owe {correctly formatted price} for this document." I think document is not the right word here - i'd use item as it's neutral to what it is (it could be anything from keys to a multi-part language course). Created attachment 106340 [details] [review] Bug 25812: Display overdue fines for the item on SIP checkin. Test plan: - Using SIP, checkin an item that has one or several overdue fines. - Check that the following message is displayed (AF field): "You owe {correctly formatted price} for this item." Thanks for the feedback, Katrin. The new patch uses item instead of document. Created attachment 139690 [details] [review] Bug 25812: Display overdue fines for the item on SIP checkin. Test plan: - Using SIP, checkin an item that has one or several overdue fines. - Check that the following message is displayed (AF field): "You owe {correctly formatted price} for this item." Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Looks good and works as designed.. I wonder if other outstanding charges associated with the patron and item combination should be taken into account.. i.e. issueing charges? Signing off, but form a QA perspective I'd love to see a Unit test. I like this, but I think it needs to be optional. It would be nice if the feature accepted a TT template so the message could be translated, but even a simple on/off switch would suffice. Created attachment 144217 [details] [review] Bug 25812: Fines can be displayed on SIP checkin/checkout This new patch adds the following: - rebased on master - adds a configuration option in SIPconfig.xml: show_outstanding_amount - extends the feature to SIP checkout - adds unit tests I'm not sure if the status should be Signed Off or Needs Signoff, since Martin has signed off before, but the feature has been extended to checkouts. Feel free to change accordingly. Also, not sure if show_outstanding_amount should be enabled or disabled by default in SIPconfig.xml. Tests look solid to me.. my signoff still stands.. just need a QA on this now :) Created attachment 144476 [details] [review] Bug 25812: Fines can be displayed on SIP checkin/checkout Test plan: - Enable show_outstanding_amount in SIPconfig.xml - Check that the total outstanding amout for the patron is displayed on SIP checkout (if it exists), for example: Patron has fines - You owe $10.00. - Check that the outstanding amout for a given item is displayed on SIP checkin (if it exists), for example: "You owe $10.00 for this item." - Check that it is not displayed when show_outstanding_amount is disabled. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! + $message .= (" - You owe " . Koha::Number::Price->new( $balance )->format({ with_symbol => 1}) . "."); .= a list? those parenthesis are not needed. |