Summary: | Add floating toolbar to the holds summary page in staff interface | ||
---|---|---|---|
Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | emmi.takkinen, george, gmcharlt, lucas, sally.healey |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
Circulation function: | |||
Bug Depends on: | 25892 | ||
Bug Blocks: | |||
Attachments: |
Bug 25827: Add floating toolbar to the holds summary page in staff interface
Bug 25827: Add floating toolbar to the holds summary page in staff interface Bug 25827: Add floating toolbar to the holds summary page in staff interface Bug 25827: Add floating toolbar to the holds summary page in staff interface |
Description
Christopher Brannon
2020-06-19 21:12:23 UTC
+1 Created attachment 106405 [details] [review] Bug 25827: Add floating toolbar to the holds summary page in staff interface This patch adds a floating toolbar to the holds summar page in the staff interface. To test, apply the patch and view the holds page for a title with multiple holds on it. Test that when you scroll down past the position of the "Update hold(s)" button, the toolbar "sticks" to the top of the screen. Test that holds are updated correctly after clicking the "Update hold(s)" button. Tested on sandbox. Applied 25892 (which I signed off), then applied 25827. The button is moved to the top, but nothing is sticking. It updates as expected, otherwise. Looks like it works in Firefox bug not Chrome. (In reply to Owen Leonard from comment #4) > Looks like it works in Firefox bug not Chrome. I can confirm I did my test in Chrome. Created attachment 106482 [details] [review] Bug 25827: Add floating toolbar to the holds summary page in staff interface This patch adds a floating toolbar to the holds summar page in the staff interface. To test, apply the patch and view the holds page for a title with multiple holds on it. Test that when you scroll down past the position of the "Update hold(s)" button, the toolbar "sticks" to the top of the screen. Test that holds are updated correctly after clicking the "Update hold(s)" button. Created attachment 106489 [details] [review] Bug 25827: Add floating toolbar to the holds summary page in staff interface This patch adds a floating toolbar to the holds summar page in the staff interface. To test, apply the patch and view the holds page for a title with multiple holds on it. Test that when you scroll down past the position of the "Update hold(s)" button, the toolbar "sticks" to the top of the screen. Test that holds are updated correctly after clicking the "Update hold(s)" button. Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Tested on Firefox and Chrome. Works as expected. Created attachment 106531 [details] [review] Bug 25827: Add floating toolbar to the holds summary page in staff interface This patch adds a floating toolbar to the holds summary page in the staff interface. To test, apply the patch and view the holds page for a title with multiple holds on it. Test that when you scroll down past the position of the "Update hold(s)" button, the toolbar "sticks" to the top of the screen. Test that holds are updated correctly after clicking the "Update hold(s)" button. Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! not backporting enhancement to 20.05.x series |