| Summary: | Cannot limit system logs to 'api' interface | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Tools | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, caroline.cyr-la-rose, chris, jonathan.druart, lucas, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement adds the option to limit viewing logged actions done by API only
|
Version(s) released in: |
20.11.00, 20.05.03
|
| Circulation function: | |||
| Bug Depends on: | 22600 | ||
| Bug Blocks: | 26086 | ||
| Attachments: |
Bug 25845: Add 'api' to the log viewer interface options
Bug 25845: Add 'api' to the log viewer interface options Bug 25845: (QA follow-up) Call it REST API instead of just API |
||
|
Description
Nick Clemens (kidclamp)
2020-06-22 19:25:44 UTC
Created attachment 106210 [details] [review] Bug 25845: Add 'api' to the log viewer interface options This patch simply adds the API option to the log viewer. To test: 1. Have BorrowersLog set 2. Update some patron using the API. For example curl --location --request PUT 'http://koha:koha@kohadev-intra.mydnsname.org:8081/api/v1/patrons/1' \ --header 'Content-Type: application/json' \ --data-raw '{ "firstname": "Tomasito", "surname": "None", "address": "Address", "category_id": "ST", "city": "Córdoba", "library_id": "MPL" }' 3. Open the log viewer => FAIL: There's no way to filter on interface, choosing API 4. Apply this patch 5. Reload the log viewer => SUCCESS: There are options to filter by 'API' interface => SUCCESS: Filtering by 'API' works 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 106421 [details] [review] Bug 25845: Add 'api' to the log viewer interface options This patch simply adds the API option to the log viewer. To test: 1. Have BorrowersLog set 2. Update some patron using the API. For example curl --location --request PUT 'http://koha:koha@kohadev-intra.mydnsname.org:8081/api/v1/patrons/1' \ --header 'Content-Type: application/json' \ --data-raw '{ "firstname": "Tomasito", "surname": "None", "address": "Address", "category_id": "ST", "city": "Córdoba", "library_id": "MPL" }' 3. Open the log viewer => FAIL: There's no way to filter on interface, choosing API 4. Apply this patch 5. Reload the log viewer => SUCCESS: There are options to filter by 'API' interface => SUCCESS: Filtering by 'API' works 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial, passing QA I think we should use "REST API", not simply "API". Created attachment 107098 [details] [review] Bug 25845: (QA follow-up) Call it REST API instead of just API Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 enhancement, not backported to 19.11.x (In reply to Aleisha Amohia from comment #8) > enhancement, not backported to 19.11.x Hi Aliesha, the api logs exist in 19.11 but cannot be searched specifically, the patch adds a string to allow selecting them. Would you reconsider? |