Summary: | Transfers page must show effective itemtype | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Circulation | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, david, gmcharlt, jonathan.druart, kyle.m.hall, lucas, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03, 19.11.09
|
|
Circulation function: | |||
Attachments: |
Bug 25868 : Fix tansfers page to show effective itemtype
Bug 25868 - Screenshots of behavour Bug 25868 : Fix tansfers page to show effective itemtype Bug 25868 : Fix tansfers page to show effective itemtype Bug 25868: Fix tansfers page to show effective itemtype |
Description
Fridolin Somers
2020-06-24 15:02:57 UTC
Created attachment 106256 [details] [review] Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Created attachment 106360 [details] Bug 25868 - Screenshots of behavour Hi Fridolin. This change now works as expected. However, if you do two transfers (one after the other for different items) the list of transfers shows: - the last transfer entered, and - the previous transfers show as "No title" and the link doesn't go anywhere See before and after screenshots. David (In reply to David Nind from comment #2) > Created attachment 106360 [details] > Bug 25868 - Screenshots of behavour > > Hi Fridolin. > > This change now works as expected. > > However, if you do two transfers (one after the other for different items) > the list of transfers shows: > - the last transfer entered, and > - the previous transfers show as "No title" and the link doesn't go anywhere > > See before and after screenshots. > > David Thanks a lot for testing, i'got a fix ;) Created attachment 106380 [details] [review] Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed <form> tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Created attachment 106385 [details] [review] Bug 25868 : Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed <form> tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfers 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Signed-off-by: David Nind <david@davidnind.com> Created attachment 106529 [details] [review] Bug 25868: Fix tansfers page to show effective itemtype In transfers page /cgi-bin/koha/circ/branchtransfers.pl : Itemtype is always from biblioitems.itemtype, regardless of system preference item-level_itypes. Patch also changes template to use the object Koha::Item. Patch also fixes a small typo : closed <form> tag. Test plan : 1) Test with both values of system preference 'item-level_itypes' 2) Go to Circulation > Transfert 3) Enter a barcode 4) Enter another barcode 5) Check you see in table all datas and that 'Item type' is correct Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 backported to 19.11.x for 19.11.09 Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |