Summary: | Patron displayed multiple times in add user search if they have multiple sub permissions | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, jonathan.druart, julian.maurice, lucas, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
20.11.00, 20.05.02, 19.11.08, 19.05.14
|
Circulation function: | |
Bug Depends on: | 24964 | ||
Bug Blocks: | |||
Attachments: |
Bug 25875: Unit test
Bug 25875: Move check for module_bit and code to the JOIN Bug 25875: Unit test Bug 25875: Move check for module_bit and code to the JOIN Bug 25875: Unit test Bug 25875: Move check for module_bit and code to the JOIN Bug 25875: Unit test |
Description
Nick Clemens (kidclamp)
2020-06-25 10:37:35 UTC
Created attachment 106283 [details] [review] Bug 25875: Unit test Created attachment 106284 [details] [review] Bug 25875: Move check for module_bit and code to the JOIN If we limit the JOIN to rows with the correct subpermission we won't duplicate the returned patrons To test: 1 - Give a patron full acquisitions permissions 2 - Also give them several subpermissions on other areas 3 - Go to Acquisitions 4 - Edit a fund 5 - Add a user to the fund 6 - Search for user above 7 - They return multiple times in results 8 - Apply patch 9 - Restart all the things 10 - Repeat search 11 - Patron appears once Created attachment 106285 [details] [review] Bug 25875: Unit test Created attachment 106286 [details] [review] Bug 25875: Move check for module_bit and code to the JOIN If we limit the JOIN to rows with the correct subpermission we won't duplicate the returned patrons To test: 1 - Give a patron full acquisitions permissions 2 - Also give them several subpermissions on other areas 3 - Go to Acquisitions 4 - Edit a fund 5 - Add a user to the fund 6 - Search for user above 7 - They return multiple times in results 8 - Apply patch 9 - Restart all the things 10 - Repeat search 11 - Patron appears once Signed-off-by: Owen Leonard <oleonard@myacpl.org> Unit tests pass even without the 2nd patch, can you take a look Nick please ? Created attachment 106341 [details] [review] Bug 25875: Unit test Created attachment 106363 [details] [review] Bug 25875: Move check for module_bit and code to the JOIN If we limit the JOIN to rows with the correct subpermission we won't duplicate the returned patrons To test: 1 - Give a patron full acquisitions permissions 2 - Also give them several subpermissions on other areas 3 - Go to Acquisitions 4 - Edit a fund 5 - Add a user to the fund 6 - Search for user above 7 - They return multiple times in results 8 - Apply patch 9 - Restart all the things 10 - Repeat search 11 - Patron appears once Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 106364 [details] [review] Bug 25875: Unit test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.02 backported to 19.11.x for 19.11.08 Backported to 19.05.x branch for 19.05.14 |