| Summary: | Clarify the visual hierarchy of holds by library and itemtype | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Hold requests | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | cbrannon, emmi.takkinen, gmcharlt, jonathan.druart, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 25827 | ||
| Attachments: |
Screenshot showing nested fieldsets
Screenshot showing the proposed revision Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype |
||
Created attachment 106402 [details]
Screenshot showing the proposed revision
Created attachment 106403 [details] [review] Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype This patch makes minor changes to the markup of the holds list to make the page hierarchy clearer when holds are grouped by branch and itemtype. Test plan: - Enable the AllowHoldItemTypeSelection system preference. - Locate a record in the catalog and place multiple holds: - Holds at different branches - Holds with different itemtypes selected - View the holds page with various values of the HoldsSplitQueue preference enabled: - nothing - pickup library - hold itemtype - pickup library & itemtype In each case verify that the interface works well. Created attachment 106412 [details] [review] Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype This patch makes minor changes to the markup of the holds list to make the page hierarchy clearer when holds are grouped by branch and itemtype. Test plan: - Enable the AllowHoldItemTypeSelection system preference. - Locate a record in the catalog and place multiple holds: - Holds at different branches - Holds with different itemtypes selected - View the holds page with various values of the HoldsSplitQueue preference enabled: - nothing - pickup library - hold itemtype - pickup library & itemtype In each case verify that the interface works well. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Works as outlined. Everything looks good. Created attachment 106488 [details] [review] Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype This patch makes minor changes to the markup of the holds list to make the page hierarchy clearer when holds are grouped by branch and itemtype. Test plan: - Enable the AllowHoldItemTypeSelection system preference. - Locate a record in the catalog and place multiple holds: - Holds at different branches - Holds with different itemtypes selected - View the holds page with various values of the HoldsSplitQueue preference enabled: - nothing - pickup library - hold itemtype - pickup library & itemtype In each case verify that the interface works well. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Created attachment 106530 [details] [review] Bug 25892: Clarify the visual hierarchy of holds by branch and itemtype This patch makes minor changes to the markup of the holds list to make the page hierarchy clearer when holds are grouped by branch and itemtype. Test plan: - Enable the AllowHoldItemTypeSelection system preference. - Locate a record in the catalog and place multiple holds: - Holds at different branches - Holds with different itemtypes selected - View the holds page with various values of the HoldsSplitQueue preference enabled: - nothing - pickup library - hold itemtype - pickup library & itemtype In each case verify that the interface works well. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! not backporting enhancement to 20.05.x series |
Created attachment 106401 [details] Screenshot showing nested fieldsets With the various settings of HoldsSplitQueue enabled the visual hierarchy of the holds list (/cgi-bin/koha/reserve/request.pl?biblionumbers=XX) can be a little muddled. See the attached screenshot. I think it would be better not to have multiple nested fieldsets and instead use a combination of fieldsets and headings.