| Summary: | aria-labels are currently not translatable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | I18N/L10N | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, bgkriegel, f.demians, jonathan.druart, julian.maurice, lucas, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03, 19.11.09
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 25244 | ||
| Attachments: |
Bug 25922: Add aria-label to the allowlist for translation
Bug 25922: Add aria-label to the allowlist for translation Bug 25922: Fix typo 'arial-label' -> 'aria-label' Bug 25922: Add aria-label to the allowlist for translation Bug 25922: Fix typo 'arial-label' -> 'aria-label' |
||
|
Description
Martin Renvoize (ashimema)
2020-07-03 13:07:14 UTC
Created attachment 106501 [details] [review] Bug 25922: Add aria-label to the allowlist for translation This patch adds aria-label to the allowlist for translations I applied this patch and patches from bug 25244, then ran `./translate update fr-FR`. I cannot find 'Select search result:' in PO files. Does it work for you ? Ah I think I found the problem (a typo). I will submit a followup Created attachment 106509 [details] [review] Bug 25922: Add aria-label to the allowlist for translation This patch adds aria-label to the allowlist for translations Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 106510 [details] [review] Bug 25922: Fix typo 'arial-label' -> 'aria-label' Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> No test plan? :( Created attachment 106532 [details] [review] Bug 25922: Add aria-label to the allowlist for translation This patch adds aria-label to the allowlist for translations. To test: - Apply patches from here and bug 25244 - kshell - cd misc/translator - perl translate update de-DE - Check for the aria-label in the diff - Verify the strings appear in the po files now - Translate them - perl translate install de-DE - Verify the translated strings appear in the template Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 106533 [details] [review] Bug 25922: Fix typo 'arial-label' -> 'aria-label' Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 backported to 19.11.x for 19.11.09 Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |