Summary: | Add ID to installed plugins table to ease styling and DOM mods | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Plugin architecture | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | aleisha, jonathan.druart, lucas, sally.healey |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03
|
|
Circulation function: | |||
Attachments: |
Bug 25953: Add class to installed plugins table on plugins-home.pl
Bug 25953: Add class to installed plugins table on plugins-home.pl Bug 25953: Add class to installed plugins table on plugins-home.pl Bug 25953: Add ID to installed plugins table on plugins-home.pl Bug 25953: Add ID to installed plugins table on plugins-home.pl |
Description
David Cook
2020-07-08 12:32:35 UTC
Ah, but right now the "Search results" are shown as a h2 under the h1 of Plugins. Created attachment 106652 [details] [review] Bug 25953: Add class to installed plugins table on plugins-home.pl This patch adds a "installed_plugins" class to the table of installed plugins. The idea is that it will ease styling and DOM mods through Javascript. Created attachment 107358 [details] [review] Bug 25953: Add class to installed plugins table on plugins-home.pl This patch adds a "installed_plugins" class to the table of installed plugins. The idea is that it will ease styling and DOM mods through Javascript. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 107370 [details] [review] Bug 25953: Add class to installed plugins table on plugins-home.pl This patch adds a "installed_plugins" class to the table of installed plugins. The idea is that it will ease styling and DOM mods through Javascript. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Why not an id? You are quite right about that... (In reply to Jonathan Druart from comment #5) > Why not an id? I have no idea. I wrote that patch around 11pm, so I must've not been thinking clearly. I'll redo this one. Created attachment 107473 [details] [review] Bug 25953: Add ID to installed plugins table on plugins-home.pl This patch adds a "installed_plugins" ID to the table of installed plugins. The idea is that it will ease styling and DOM mods through Javascript. Created attachment 107558 [details] [review] Bug 25953: Add ID to installed plugins table on plugins-home.pl This patch adds a "installed_plugins" ID to the table of installed plugins. The idea is that it will ease styling and DOM mods through Javascript. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> A small patch - using my QA powers here... Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 enhancement, not backported to 19.11.x |