| Summary: | Add 'library' relation to Koha::Account::Line | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Architecture, internals, and plumbing | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, kyle, lucas, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 24381 | ||
| Attachments: |
Bug 25998: Add 'library' relation to Koha::Account::Line
Bug 25998: Add Unit Tests Bug 25998: Add 'library' relation to Koha::Account::Line Bug 25998: (QA follow-up) Add DBIC level relation Bug 25998: Add Unit Tests Bug 25998: Add 'library' relation to Koha::Account::Line Bug 25998: (QA follow-up) Add DBIC level relation |
||
|
Description
Martin Renvoize (ashimema)
2020-07-16 11:09:23 UTC
Created attachment 106945 [details] [review] Bug 25998: Add 'library' relation to Koha::Account::Line Create the 'library' DBIC relationship also, so we can prefetch it in the API. (In reply to Tomás Cohen Arazi from comment #2) > Create the 'library' DBIC relationship also, so we can prefetch it in the > API. Good catch.. I forgot we were doing that now :) Created attachment 106971 [details] [review] Bug 25998: Add Unit Tests Created attachment 106972 [details] [review] Bug 25998: Add 'library' relation to Koha::Account::Line Created attachment 106973 [details] [review] Bug 25998: (QA follow-up) Add DBIC level relation Tests added and relation updated dbic side, ready for SO Created attachment 107122 [details] [review] Bug 25998: Add Unit Tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 107123 [details] [review] Bug 25998: Add 'library' relation to Koha::Account::Line Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 107124 [details] [review] Bug 25998: (QA follow-up) Add DBIC level relation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Trivial patchset with no QA errors and following the current coding guidelines. Passing QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 enhancement, not backporting to 19.11.x |