Bug 26009

Summary: Elasticsearch homebranch and holdingbranch facets are limited to 10
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Searching - ElasticsearchAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: normal    
Priority: P5 - low CC: aleisha, black23, josef.moravec, lucas, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.03, 19.11.09
Attachments: Bug 26009: Add facet size to home/holdingbranch
Bug 26009: Add facet size to home/holdingbranch
Bug 26009: Add facet size to home/holdingbranch
Bug 26009: (QA follow-up) It does not harm to test more

Description Nick Clemens (kidclamp) 2020-07-17 16:01:27 UTC
bug 14419 added the 'size' parameter to most facets, but home/holdingbranch were missed
Comment 1 Nick Clemens (kidclamp) 2020-07-17 16:27:03 UTC
Created attachment 107044 [details] [review]
Bug 26009: Add facet size to home/holdingbranch

To test:
0 - Set DisplayLibraryFacets to 'both' and FacetMaxCount to 20
1 - Have more than 10 branches
2 - Have items in each of those branches
3 - Enable ES, set system preference SearchEngine to Elasticsearch
4 - Search for '*'
5 - Expand homebranch/holdingbranch facets
6 - Note you only get 10
7 - Apply patch
8 - Repeat search
9 - Now you get all your facets
Comment 2 Andrew Fuerste-Henry 2020-08-03 17:25:50 UTC
Created attachment 107717 [details] [review]
Bug 26009: Add facet size to home/holdingbranch

To test:
0 - Set DisplayLibraryFacets to 'both' and FacetMaxCount to 20
1 - Have more than 10 branches
2 - Have items in each of those branches
3 - Enable ES, set system preference SearchEngine to Elasticsearch
4 - Search for '*'
5 - Expand homebranch/holdingbranch facets
6 - Note you only get 10
7 - Apply patch
8 - Repeat search
9 - Now you get all your facets

Signed-off-by: Michael Springer <mspringer@mylakelibrary.org>
Comment 3 Josef Moravec 2020-08-06 19:17:20 UTC
Created attachment 107916 [details] [review]
Bug 26009: Add facet size to home/holdingbranch

To test:
0 - Set DisplayLibraryFacets to 'both' and FacetMaxCount to 20
1 - Have more than 10 branches
2 - Have items in each of those branches
3 - Enable ES, set system preference SearchEngine to Elasticsearch
4 - Search for '*'
5 - Expand homebranch/holdingbranch facets
6 - Note you only get 10
7 - Apply patch
8 - Repeat search
9 - Now you get all your facets

Signed-off-by: Michael Springer <mspringer@mylakelibrary.org>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Josef Moravec 2020-08-06 19:17:26 UTC
Created attachment 107917 [details] [review]
Bug 26009: (QA follow-up) It does not harm to test more

Test plan:
prove t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
--> should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Jonathan Druart 2020-08-07 14:56:11 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 6 Lucas Gass 2020-08-14 21:55:26 UTC
backported to 20.05.x for 20.05.03
Comment 7 Aleisha Amohia 2020-08-16 22:54:52 UTC
backported to 19.11.x for 19.11.09
Comment 8 Victor Grousset/tuxayo 2020-09-20 14:17:56 UTC
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.