|
Description
Tomás Cohen Arazi (tcohen)
2020-07-24 19:00:15 UTC
Created attachment 107366 [details] [review] Bug 26063: Use Koha::Plugins->call for circulation hooks This patch gets rid of a helper method used for calling the plugin hooks. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> It does not apply on top of 24031 Applying: Bug 26063: Use Koha::Plugins->call for circulation hooks error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 26063: Use Koha::Plugins->call for circulation hooks Neither on top of the PQA hook related patch. Please build this on top of bug 25961, bug 25855 and bug 24031. Fixed the dependencies. Tomas, I thought that the plan was to use Koha::Plugins->call everywhere. This patch is only using it for circulation hooks. Can we have a plan for that as well please? Created attachment 107498 [details] [review] Bug 26063: Use Koha::Plugins->call for some other hooks Are there other hooks not covered? (I did not test this last patch!) Created attachment 107561 [details] [review] Bug 26063: Use Koha::Plugins->call for some other hooks Created attachment 107562 [details] [review] Bug 26063: Use Koha::Plugins->call for some other hooks Created attachment 107595 [details] [review] Bug 26063: Use Koha::Plugins->call for circulation hooks This patch gets rid of a helper method used for calling the plugin hooks. To test: 1. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 107596 [details] [review] Bug 26063: Use Koha::Plugins->call for some other hooks Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 20.11, thanks to everybody involved! Has anyone tested this without a plugin installed? I tried to do an OPAC search on a fresh install of master and I'm getting errors.
Can't use string ("0") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/opac/opac-search.pl line 661
I have opened Bug 26138 as this patch causes a bug when enable_plugins is 0. enhancement will not be backported to 20.05.x series |