| Summary: | Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | f.demians, jonathan.druart, lucas, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 21156 | ||
| Bug Blocks: | 25694 | ||
| Attachments: |
Bug 26065: Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js
Bug 26065: Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js |
||
|
Description
Owen Leonard
2020-07-24 23:10:04 UTC
Created attachment 107430 [details] [review] Bug 26065: Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js This patch removes the <script> block in the MARC modification templates template in which strings are defined for translation purposes. Strings are now in place in the JavaScript file and wrapped in the new __() function. To test, apply the patch and clear your browser cache if necessary. - Perform some actions which will trigger translated strings, for example: - Create a new template - Add an action to the template and then delete it. - The confirmation should appear correctly - Add an action. Select "Copy" as the operation and click "Add action" without filling in any fields. - You should see a message, "Both subfield values should be filled or empty" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js for translation, e.g.: msgid "Both subfield values should be filled or empty." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated string should appear. Created attachment 107550 [details] [review] Bug 26065: Move translatable strings out of marc_modification_templates.tt and into marc_modification_templates.js This patch removes the <script> block in the MARC modification templates template in which strings are defined for translation purposes. Strings are now in place in the JavaScript file and wrapped in the new __() function. To test, apply the patch and clear your browser cache if necessary. - Perform some actions which will trigger translated strings, for example: - Create a new template - Add an action to the template and then delete it. - The confirmation should appear correctly - Add an action. Select "Copy" as the operation and click "Add action" without filling in any fields. - You should see a message, "Both subfield values should be filled or empty" TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/marc_modification_templates.js for translation, e.g.: msgid "Both subfield values should be filled or empty." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated string should appear. Skipping QA, I will review it myself. Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |