| Summary: | Add column configuration and export options to catalog statistics report | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, koha-bugs, lucas, sally.healey, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 19282 | ||
| Attachments: |
Bug 26091: Add column configuration and export options to catalog statistics report
Bug 26091: Add column configuration and export options to catalog statistics report Bug 26091: Add column configuration and export options to catalog statistics report Bug 26091: (follow-up) Remove unused TablesSettings usage |
||
|
Description
Owen Leonard
2020-07-29 16:15:02 UTC
Created attachment 107519 [details] [review] Bug 26091: Add column configuration and export options to catalog statistics report This patch makes the catalog statistics report output a DataTable with on-the-fly column configuration and export options. Because the report can generate results with an arbitrary set of table headers, the columns set to be passed to DataTables is built on the fly along with the table. There is no global table setting. Since the "grand total" cell might reflect a total which includes hidden columns, the table footer label now indicates "all results." To test, apply the patch and go to Reports. - Submit a query to the "catalog" statistics wizard which will return multiple results. - On the results page, confirm that the DataTable displays correctly and that all controls work as expected, including column configuration and export options. - Submit other queries which will return a different set of columns in the result. Confirm that everything continues to work as expected. Created attachment 107790 [details] [review] Bug 26091: Add column configuration and export options to catalog statistics report This patch makes the catalog statistics report output a DataTable with on-the-fly column configuration and export options. Because the report can generate results with an arbitrary set of table headers, the columns set to be passed to DataTables is built on the fly along with the table. There is no global table setting. Since the "grand total" cell might reflect a total which includes hidden columns, the table footer label now indicates "all results." To test, apply the patch and go to Reports. - Submit a query to the "catalog" statistics wizard which will return multiple results. - On the results page, confirm that the DataTable displays correctly and that all controls work as expected, including column configuration and export options. - Submit other queries which will return a different set of columns in the result. Confirm that everything continues to work as expected. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 107956 [details] [review] Bug 26091: Add column configuration and export options to catalog statistics report This patch makes the catalog statistics report output a DataTable with on-the-fly column configuration and export options. Because the report can generate results with an arbitrary set of table headers, the columns set to be passed to DataTables is built on the fly along with the table. There is no global table setting. Since the "grand total" cell might reflect a total which includes hidden columns, the table footer label now indicates "all results." To test, apply the patch and go to Reports. - Submit a query to the "catalog" statistics wizard which will return multiple results. - On the results page, confirm that the DataTable displays correctly and that all controls work as expected, including column configuration and export options. - Submit other queries which will return a different set of columns in the result. Confirm that everything continues to work as expected. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Happy to have this patch, but wish we did a bit better for translations etc on those reports. Comment on attachment 107956 [details] [review] Bug 26091: Add column configuration and export options to catalog statistics report Review of attachment 107956 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt @@ +1,2 @@ > [% USE Branches %] > +[% USE TablesSettings %] We should not need that. Owen can you confirm? Created attachment 108155 [details] [review] Bug 26091: (follow-up) Remove unused TablesSettings usage Since the table column information is built in the template rather than in the columns_settings YML file we don't need "USE TablesSettings" in this template. Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |