Bug 26094

Summary: "Suggest for Purchase" button missing unique CSS class
Product: Koha Reporter: Hannah Co <hannah.co>
Component: OPACAssignee: Jonathan Druart <jonathan.druart+koha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: aleisha, jonathan.druart+koha, lucas, sally.healey
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.03
Attachments: Bug 26094: Add class to the "Suggest for purchase" button
Bug 26094: Add class to the "Suggest for purchase" button
Bug 26094: Add class to the "Suggest for purchase" button

Description Hannah Co 2020-07-29 18:12:45 UTC
"Suggest for purchase" has no class for CSS manipulation. The other opac-detail-sidebar.inc buttons each have a class on the link element ("reserve" or "print-large") so they can be hidden or appearance changed using CSS. 

I don't think adding/changing system preferences is necessary, just adding a class to the link in Koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc (currently on line 37)
Comment 1 Jonathan Druart 2020-07-30 12:42:18 UTC
Created attachment 107583 [details] [review]
Bug 26094: Add class to the "Suggest for purchase" button

Bug 14963 added a new "Suggest for purchase" button on the detail page
of bibliographic records at the OPAC.
This patch adds a specific CSS class to make it reachable easily

Like others button in this action list

Test plan:
Go to the detail page of a bibliographic record at the OPAc
Notice the new CSS class
Comment 2 ByWater Sandboxes 2020-07-31 09:09:18 UTC
Created attachment 107622 [details] [review]
Bug 26094: Add class to the "Suggest for purchase" button

Bug 14963 added a new "Suggest for purchase" button on the detail page
of bibliographic records at the OPAC.
This patch adds a specific CSS class to make it reachable easily

Like others button in this action list

Test plan:
Go to the detail page of a bibliographic record at the OPAc
Notice the new CSS class

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Nick Clemens 2020-07-31 15:27:38 UTC
Created attachment 107649 [details] [review]
Bug 26094: Add class to the "Suggest for purchase" button

Bug 14963 added a new "Suggest for purchase" button on the detail page
of bibliographic records at the OPAC.
This patch adds a specific CSS class to make it reachable easily

Like others button in this action list

Test plan:
Go to the detail page of a bibliographic record at the OPAc
Notice the new CSS class

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Jonathan Druart 2020-08-03 09:59:46 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 5 Lucas Gass 2020-08-13 17:32:04 UTC
backported to 20.05.x for 20.05.03
Comment 6 Aleisha Amohia 2020-08-16 21:23:06 UTC
enhancement, not backported to 19.11.x