Bug 26098

Summary: JS error on the fund list view if no fund displayed
Product: Koha Reporter: Jonathan Druart <jonathan.druart+koha>
Component: TemplatesAssignee: Jonathan Druart <jonathan.druart+koha>
Status: Pushed to oldstable --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: aleisha, lucas, victor
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25887
Change sponsored?: --- Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.03, 19.11.09
Attachments: Bug 26098: Fix JS error on the fund list view when no fund displayed
Bug 26098: Fix JS error on the fund list view when no fund displayed
Bug 26098: Fix JS error on the fund list view when no fund displayed

Description Jonathan Druart 2020-07-30 09:01:52 UTC
To recreate, go to the fund list view, select a filter that will return no result.
A JS error is displayed in the console:
    TypeError: this.data(...) is undefined
coming from jquery.treetable.js
Comment 1 Jonathan Druart 2020-07-30 09:03:04 UTC
Created attachment 107566 [details] [review]
Bug 26098: Fix JS error on the fund list view when no fund displayed

TypeError: this.data(...) is undefined
in jquery.treetable.js

Test plan:
Go to the fund list view
Select a filter that will return no result
=> With this patch applied there is no JS error in the console
Comment 2 Lucas Gass 2020-07-31 21:56:23 UTC
Created attachment 107657 [details] [review]
Bug 26098: Fix JS error on the fund list view when no fund displayed

TypeError: this.data(...) is undefined
in jquery.treetable.js

Test plan:
Go to the fund list view
Select a filter that will return no result
=> With this patch applied there is no JS error in the console

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2020-08-05 16:34:33 UTC
Created attachment 107847 [details] [review]
Bug 26098: Fix JS error on the fund list view when no fund displayed

TypeError: this.data(...) is undefined
in jquery.treetable.js

Test plan:
Go to the fund list view
Select a filter that will return no result
=> With this patch applied there is no JS error in the console

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2020-08-06 09:38:21 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 5 Lucas Gass 2020-08-14 21:05:55 UTC
backported to 20.05.x for 20.05.03
Comment 6 Aleisha Amohia 2020-08-16 22:28:11 UTC
backported to 19.11.x for 19.11.09
Comment 7 Victor Grousset/tuxayo 2020-09-20 13:33:11 UTC
Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed.