Summary: | When reporting an Error from the OPAC, the URL does not display | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04
|
|
Bug Depends on: | 4461 | ||
Bug Blocks: | |||
Attachments: |
opac
Bug 26127: local_referer should not compare with OPACBaseURL case insensitive url Bug 26127: local_referer should not compare with OPACBaseURL case insensitive Bug 26127: local_referer should not compare with OPACBaseURL case insensitive Bug 26127: local_referer should not compare with OPACBaseURL case insensitive |
Description
Kelly McElligott
2020-08-03 11:51:24 UTC
Hi Kelly, can you confirm you have OPACBaseURL set correctly? Hi Jonathan, yes, I have the OPACbaseURL set up. It is working and directing staff to OPAC via bib records. Created attachment 107704 [details] [review] Bug 26127: local_referer should not compare with OPACBaseURL case insensitive In our test data we have OPACBaseURL that is filled with http://kohadev.myDNSname.org:8080, but the CGI referer in local_referer is lowercase We should compare it without case sensitivity Can you test this patch? It's just a guess but I do recreate on koha-testing-docker and it fixes the problem. This is still not working when testing in Sandboxes. Adding screenshots. Created attachment 107710 [details]
url
I could see this problem when my OpacBaseURL system preference didn't match my actual OPAC URL. In my case it was because the OpacBaseURL from the sample data doesn't match my test environment. Is the same true of the sandboxes? Sandboxes should have the same case sensitive problem my patch is supposed to fix. Created attachment 107744 [details] [review] Bug 26127: local_referer should not compare with OPACBaseURL case insensitive In our test data we have OPACBaseURL that is filled with http://kohadev.myDNSname.org:8080, but the CGI referer in local_referer is lowercase We should compare it without case sensitivity Test plan: - Use koha-testing-docker - Notice the value of OPACBaseURL => http://kohadev.myDNSname.org:8080 - Use the "reports a problem" feature at the OPAC - Notice that the "Problem found on page" is correctly filled with the referer The original problem is also due to an issue in koha-sandboxes-docker, reported at https://github.com/bywatersolutions/koha-sandboxes-docker/issues/37 Created attachment 108094 [details] [review] Bug 26127: local_referer should not compare with OPACBaseURL case insensitive In our test data we have OPACBaseURL that is filled with http://kohadev.myDNSname.org:8080, but the CGI referer in local_referer is lowercase We should compare it without case sensitivity Test plan: - Use koha-testing-docker - Notice the value of OPACBaseURL => http://kohadev.myDNSname.org:8080 - Use the "reports a problem" feature at the OPAC - Notice that the "Problem found on page" is correctly filled with the referer Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Created attachment 108317 [details] [review] Bug 26127: local_referer should not compare with OPACBaseURL case insensitive In our test data we have OPACBaseURL that is filled with http://kohadev.myDNSname.org:8080, but the CGI referer in local_referer is lowercase We should compare it without case sensitivity Test plan: - Use koha-testing-docker - Notice the value of OPACBaseURL => http://kohadev.myDNSname.org:8080 - Use the "reports a problem" feature at the OPAC - Notice that the "Problem found on page" is correctly filled with the referer Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 missing dependencies, not backported to 19.11.x *** Bug 27468 has been marked as a duplicate of this bug. *** |