Bug 26131

Summary: console errors when attempting to open SCO related system preferences
Product: Koha Reporter: Lucas Gass <lucas>
Component: Self checkoutAssignee: Lucas Gass <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: aleisha, nick, sally.healey
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.11.00, 20.05.03
Bug Depends on: 25147    
Bug Blocks: 15851    
Attachments: Bug 26131: Remove parentheses in circulation.pref
Bug 26131: Remove parentheses in circulation.pref
Bug 26131: Remove parentheses in circulation.pref

Description Lucas Gass 2020-08-03 21:47:53 UTC
When you search for SCO related system preferences you will get a console error:

Uncaught Error: Syntax error, unrecognized expression: #collapse_Self_check-in_module_(sci-main.pl)

This makes it impossible to open/edit the system preference.
Comment 1 Lucas Gass 2020-08-03 21:59:36 UTC Comment hidden (obsolete)
Comment 2 ByWater Sandboxes 2020-08-04 09:15:58 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens 2020-08-04 13:07:18 UTC
Created attachment 107761 [details] [review]
Bug 26131: Remove parentheses in circulation.pref

To test:
1. Search for a SCO system preference like SCOUserJS.
2. Note that there is a console error on that screen and you cannot open editor.
3. Apply patch
4. Reload the page.
5. No more console error and you can now edit the system pref!

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Jonathan Druart 2020-08-06 09:38:38 UTC
Pushed to master for 20.11, thanks to everybody involved!
Comment 5 Lucas Gass 2020-08-14 21:11:40 UTC
backported to 20.05.x for 20.05.03
Comment 6 Aleisha Amohia 2020-08-16 22:30:55 UTC
missing dependencies, not backported to 19.11.x