| Summary: | Unneeded calls in detail.pl can be removed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, lucas, martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 26133: Remove GetMarc* calls in detail.pl
Bug 26133: Remove GetMarcHosts Bug 26133: Remove GetMarc* calls in detail.pl Bug 26133: Remove GetMarcHosts |
||
|
Description
Jonathan Druart
2020-08-04 11:57:17 UTC
Created attachment 107748 [details] [review] Bug 26133: Remove GetMarc* calls in detail.pl There are several calls in catalogue/detail.pl that can be removed: GetMarcISBN, GetMarcAuthors, GetMarcSubjects, GetMarcSeries, GetMarcUrls and GetMarcHosts They pass a variable to the template that is never used. Test plan: Confirm that this TT variable is never used. Created attachment 107749 [details] [review] Bug 26133: Remove GetMarcHosts We removed the single occurrence of this subroutine in the previous patch Created attachment 107826 [details] [review] Bug 26133: Remove GetMarc* calls in detail.pl There are several calls in catalogue/detail.pl that can be removed: GetMarcISBN, GetMarcAuthors, GetMarcSubjects, GetMarcSeries, GetMarcUrls and GetMarcHosts They pass a variable to the template that is never used. Test plan: Confirm that this TT variable is never used. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 107827 [details] [review] Bug 26133: Remove GetMarcHosts We removed the single occurrence of this subroutine in the previous patch Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Going straight for QA on this one.. verified the variables are not referenced in the relevant templates and done a little investigation to see when they were removed which yielded nothing of concern. Passing QA Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.03 enhancement, not backported to 19.11.x |