Summary: | Error when adding to basket from new/staged file when using MARCItemFieldsToOrder | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrewfh> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | critical | ||
Priority: | P5 - low | CC: | aleisha, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04
|
|
Bug Depends on: | 23463 | ||
Bug Blocks: | |||
Attachments: |
Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file
Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file |
Description
Andrew Fuerste-Henry
2020-08-04 12:29:58 UTC
Caused by commit 2075a22ed3c71196002dd8da28a061f791baf393 Bug 23463: Replace AddItem calls with Koha::Item->store Created attachment 107873 [details] [review] Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file There is a ->store call missing when we attempt to create a new item. Test plan: - set at least one value in MARCItemFieldsToOrder - add to a basket via staged file with at least one value matching your MARCItemFields mappings - set required fields for your order and click Save => Without this patch you got: receive error: "DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null at /kohadevbox/koha/Koha/Acquisition/Order.pm line 113 at /usr/share/perl5/DBIx/Class/Exception.pm line 77" => With this patch applied the order has been created successfully Created attachment 108158 [details] [review] Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file There is a ->store call missing when we attempt to create a new item. Test plan: - set at least one value in MARCItemFieldsToOrder - add to a basket via staged file with at least one value matching your MARCItemFields mappings - set required fields for your order and click Save => Without this patch you got: receive error: "DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null at /kohadevbox/koha/Koha/Acquisition/Order.pm line 113 at /usr/share/perl5/DBIx/Class/Exception.pm line 77" => With this patch applied the order has been created successfully Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 108316 [details] [review] Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file There is a ->store call missing when we attempt to create a new item. Test plan: - set at least one value in MARCItemFieldsToOrder - add to a basket via staged file with at least one value matching your MARCItemFields mappings - set required fields for your order and click Save => Without this patch you got: receive error: "DBIx::Class::Storage::DBI::_dbh_execute(): Column 'itemnumber' cannot be null at /kohadevbox/koha/Koha/Acquisition/Order.pm line 113 at /usr/share/perl5/DBIx/Class/Exception.pm line 77" => With this patch applied the order has been created successfully Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 missing dependencies, not backported to 19.11.x |