| Summary: | Errors if enable_plugins is zero | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> | 
| Component: | Plugin architecture | Assignee: | Jonathan Druart <jonathan.druart> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | blocker | ||
| Priority: | P5 - low | CC: | jonathan.druart, lucas, martin.renvoize | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | 
       20.11.00 
 | 
        
        Circulation function: | |
| Bug Depends on: | 26063 | ||
| Bug Blocks: | |||
| Attachments: | 
              Bug 26138: Make Koha::Plugins->call return consistent value
               Bug 26138: Make Koha::Plugins->call return consistent value Bug 26138: Make Koha::Plugins->call return consistent value  | 
      ||
| 
 
        
          Description
        
        
          Aleisha Amohia
        
        
        
        
          2020-08-04 22:01:18 UTC
        
       
    Created attachment 107819 [details] [review] Bug 26138: Make Koha::Plugins->call return consistent value It must return an empty array in case the enable_plugins config flag is disabled Test plan: Turn the config off in koha-conf Start a search at the OPAC Without this patch you got: Can't use string ("0") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/opac/opac-search.pl line 661 With this patch applied you see the search result Created attachment 107825 [details] [review] Bug 26138: Make Koha::Plugins->call return consistent value It must return an empty array in case the enable_plugins config flag is disabled Test plan: Turn the config off in koha-conf Start a search at the OPAC Without this patch you got: Can't use string ("0") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/opac/opac-search.pl line 661 With this patch applied you see the search result Followed test plan - works as described. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Created attachment 107830 [details] [review] Bug 26138: Make Koha::Plugins->call return consistent value It must return an empty array in case the enable_plugins config flag is disabled Test plan: Turn the config off in koha-conf Start a search at the OPAC Without this patch you got: Can't use string ("0") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/opac/opac-search.pl line 661 With this patch applied you see the search result Followed test plan - works as described. Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Clear and consistent fix works as described. Passes QA scripts and no regressions found. Passing QA Pushed to master for 20.11, thanks to everybody involved! doesn't apply clean to 20.05.x, will need a rebase  |