| Summary: | Remove jquery.checkboxes plugin from problem reports page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, lucas, martin.renvoize, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 26006 | ||
| Attachments: |
Bug 26149: Remove jquery.checkboxes plugin from problem reports page
Bug 26194: Add link to cash register management from message about missing registers Bug 26194: (follow-up) Default to current branch Bug 26149: Remove jquery.checkboxes plugin from problem reports page Bug 26149: Remove jquery.checkboxes plugin from problem reports page |
||
|
Description
Owen Leonard
2020-08-05 16:05:55 UTC
Created attachment 107849 [details] [review] Bug 26149: Remove jquery.checkboxes plugin from problem reports page This patch removes the inclusion of the jquery.checkboxes plugin from the problem reports template in the staff interface. To test, apply the patch and make sure the OPACReportProblem system preference is enabled. - Submit a few OPAC problem reports if necessary - Go to Tools -> OPAC problem reports - Test that the "Select all" and "Clear all" controls at the top of the table work correctly. Created attachment 108125 [details] [review] Bug 26194: Add link to cash register management from message about missing registers In places where the interface warns the user about missing cash registers we should provide users with permission a direct link to the cash register management page. To test, apply the patch and enable the UseCashRegisters and EnablePointOfSale preferences. If necessary, go to Administration -> Cash registers and remove any cash registers for your library. - Log in to the staff interface as a user with "manage_cash_registers" permission. - Locate a patron who has outstanding fines. - Under Accounting -> Make a payment, click the "Pay" button next to a fine. - The page should show the message about missing cash registers with a button which take you directly to the "Add new cash register" form. - Perform the same check by selecting the checkbox next to a fine and clicking the "Pay amount" button and the "Pay selected" button. - Test the message shown at: - Tools -> Cashup registers. - Point of sale -> Register details - Point of sale -> Library details - Perform the same tests when logged in as a user without permission to manage cash registers. The messages shown in the previous steps should omit the button linking to cash register management. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 108126 [details] [review] Bug 26194: (follow-up) Default to current branch When adding a new register, it would be helpful to default to the current logged in branch. Bug number typo. Created attachment 108129 [details] [review] Bug 26149: Remove jquery.checkboxes plugin from problem reports page This patch removes the inclusion of the jquery.checkboxes plugin from the problem reports template in the staff interface. To test, apply the patch and make sure the OPACReportProblem system preference is enabled. - Submit a few OPAC problem reports if necessary - Go to Tools -> OPAC problem reports - Test that the "Select all" and "Clear all" controls at the top of the table work correctly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> No regressions.. Signing off. Created attachment 108312 [details] [review] Bug 26149: Remove jquery.checkboxes plugin from problem reports page This patch removes the inclusion of the jquery.checkboxes plugin from the problem reports template in the staff interface. To test, apply the patch and make sure the OPACReportProblem system preference is enabled. - Submit a few OPAC problem reports if necessary - Go to Tools -> OPAC problem reports - Test that the "Select all" and "Clear all" controls at the top of the table work correctly. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 enhancement, not backported to 19.11.x |