Summary: | Remove the use of jquery.checkboxes plugin from suggestions management page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, lucas, testopia |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.05
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 26006 | ||
Attachments: |
Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page
Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page |
Description
Owen Leonard
2020-08-05 17:26:54 UTC
Created attachment 107854 [details] [review] Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page This patch removes the use of the jquery.checkboxes plugin from the suggestions management page and replaces it with custom JS. To test, apply the patch and go to Acquisitions -> Suggestions Under each tab ("Accepted," "Pending," etc.), test that the "Check all" and "Uncheck all" controls work correctly and only affect the table on that tab. Created attachment 110112 [details] [review] Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page This patch removes the use of the jquery.checkboxes plugin from the suggestions management page and replaces it with custom JS. To test, apply the patch and go to Acquisitions -> Suggestions Under each tab ("Accepted," "Pending," etc.), test that the "Check all" and "Uncheck all" controls work correctly and only affect the table on that tab. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Created attachment 110125 [details] [review] Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page This patch removes the use of the jquery.checkboxes plugin from the suggestions management page and replaces it with custom JS. To test, apply the patch and go to Acquisitions -> Suggestions Under each tab ("Accepted," "Pending," etc.), test that the "Check all" and "Uncheck all" controls work correctly and only affect the table on that tab. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.05 enhancement, not backported to 19.11.x |