Summary: | Remove redundant import of Google font | ||
---|---|---|---|
Product: | Koha | Reporter: | Timothy Alexis Vass <timothy_alexis.vass> |
Component: | OPAC | Assignee: | Timothy Alexis Vass <timothy_alexis.vass> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | aleisha, jonathan.druart, lucas |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.03
|
|
Attachments: |
Removed redundant @import of google font
Bug 26179: Remove redundant import of Google font Bug 26179: Remove redundant import of Google font |
Description
Timothy Alexis Vass
2020-08-07 12:57:19 UTC
Created attachment 107954 [details] [review] Removed redundant @import of google font Created attachment 107969 [details] [review] Bug 26179: Remove redundant import of Google font Removed redundant @import of google font Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 108010 [details] [review] Bug 26179: Remove redundant import of Google font Removed redundant @import of google font Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=26170 I don't understand, can you explain what we are doing here? 12:30 TimothyAlexis In bootstrap-theme.oai.css we found this and we are wondering... why? @import url("//fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,700,400italic"); 12:30 TimothyAlexis body { 12:30 font-family: "Source Sans Pro", "Helvetica Neue", Helvetica, Arial, sans-serif; 12:32 Only place I've found this stylesheet being used is in: koha-tmpl/opac-tmpl/xslt/OAI.xslt 12:48 tcohen TimothyAlexis that's because I borrowed the XSLT from DSpace and didn't notice that Simply removing the @import and "Source Sans Pro". Pushed to master for 20.11, thanks to everybody involved! This is your first patch pushed, Timothy, congrats! :) backported to 20.05.x for 20.05.03 enhancement, not backported to 19.11.x |