| Summary: | Clearly pair UpdateItemWhenLostFromHoldList and CanMarkHoldsToPullAsLost system preferences | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Staff interface | Assignee: | Andrew Fuerste-Henry <andrew> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, bwsdonna, caroline.cyr-la-rose, gmcharlt, hc, jonathan.druart, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04
|
|
| Circulation function: | |||
| Attachments: |
Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList
Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList |
||
|
Description
Andrew Fuerste-Henry
2020-08-07 16:32:16 UTC
I would suggest adding a note to the sys pref description. That seems to be the standard now, and I am always for more info in the descriptions! (In reply to Andrew Fuerste-Henry from comment #0) > If you have CanMarkHoldsToPullAsLost turned on but don't have a value in > UpdateItemWhenLostFromHoldList, the Holds to Pull list will give you a "Mark > item as Lost" button, but the item will not be marked as lost. Reading the code I don't think it's what happens. If CanMarkHoldsToPullAsLost is on, the item will be mark as lost, however if you have something in UpdateItemWhenLostFromHoldList but CanMarkHoldsToPullAsLost is off, then UpdateItemWhenLostFromHoldList will not be applied. Can you confirm? Here's what I see from playing with combinations of these two sysprefs on master: CanMarkHoldsToPullAsLost controls whether or not the "Mark item as lost" button shows on the Holds to Pull page. UpdateItemWhenLostFromHoldList controls what the button does. If CanMarkHoldsToPullAsLost is set to "Allow to mark items as lost" and UpdateItemWhenLostFromHoldList is empty, we get a "Mark item as lost" button, but clicking it just cancels the hold without making the item lost. If CanMarkHoldsToPullAsLost is set to "Do not allow to mark items as lost" and UpdateItemWhenLostFromHoldList has "itemlost: 1," we do not get a "Mark item as lost" button. Created attachment 108179 [details] [review] Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList To test: - apply patch, restart - search sysprefs for CanMarkHoldsToPullAsLost - confirm both sysprefs come up in search and syspref descriptions refer to each other Created attachment 108192 [details] [review] Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList To test: - apply patch, restart - search sysprefs for CanMarkHoldsToPullAsLost - confirm both sysprefs come up in search and syspref descriptions refer to each other Signed-off-by: Holly Cooper <holly.teresa.cooper@gmail.com> Created attachment 108315 [details] [review] Bug 26182: Clarify wording on CanMarkHoldsToPullAsLost and UpdateItemWhenLostFromHoldList To test: - apply patch, restart - search sysprefs for CanMarkHoldsToPullAsLost - confirm both sysprefs come up in search and syspref descriptions refer to each other Signed-off-by: Holly Cooper <holly.teresa.cooper@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 20.11, thanks to everybody involved! backported to 20.05.x for 20.05.04 enhancement, not backported to 19.11.x |